-
Notifications
You must be signed in to change notification settings - Fork 379
adrienne / added assets folder and mock svg #9841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…' into farzin/next
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-assets-r-d.binary.sx/ |
fontSize: 30, | ||
}} | ||
> | ||
<IcBrandingDerivEzDashboard width={50} height={50} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about background image in scss ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to put the assets inside public
folder so we can use it in scss right? is it correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we had difficulties before for svg in scss, we needed webpack for it to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wallets is imported within appstore folder, thus its using the webpack config inside appstore which already has a svg loader
Kudos, SonarCloud Quality Gate passed!
|
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.