Skip to content

Conversation

adrienne-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 28, 2023 8:47am

@adrienne-deriv adrienne-deriv marked this pull request as ready for review August 28, 2023 08:18
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9841](https://github.com/binary-com/deriv-app/pull/9841)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-assets-r-d.binary.sx?qa_server=red.binaryws.com&app_id=32930
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-assets-r-d.binary.sx
- **App ID**: `32930`

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-assets-r-d.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 10.039%. first build when pulling 4530aa6 on adrienne-deriv:assets-r-d into 04eebe8 on binary-com:master.

fontSize: 30,
}}
>
<IcBrandingDerivEzDashboard width={50} height={50} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about background image in scss ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to put the assets inside public folder so we can use it in scss right? is it correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we had difficulties before for svg in scss, we needed webpack for it to work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wallets is imported within appstore folder, thus its using the webpack config inside appstore which already has a svg loader

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.2% 5.2% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants