Skip to content

feat: 🍄 updated PWA icon and color as per the latest branding #9966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 22, 2023
Merged

feat: 🍄 updated PWA icon and color as per the latest branding #9966

merged 13 commits into from
Sep 22, 2023

Conversation

@shaheer-deriv
Copy link
Contributor

@shaheer-deriv shaheer-deriv commented Sep 6, 2023 •
edited
Loading

Changes:

  • Updated PWA brand color
  • Added app id to suppress developer warning and to prevent fallback to start_url.
  • Updated PWA brand logo(square icons used, as this ensures safe and smooth clipping in all devices)

Screenshots:

Screenshot 2023-09-14 at 3 51 37 PM

@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 14, 2023 1:51pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/9966](https://github.com/binary-com/deriv-app/pull/9966)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shaheer-deriv-shaheer-wall-1420.binary.sx?qa_server=red.binaryws.com&app_id=31584
    - **Original**: https://deriv-app-git-fork-shaheer-deriv-shaheer-wall-1420.binary.sx
- **App ID**: `31584`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 17
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-shaheer-deriv-shaheer-wall-1420.binary.sx/

maryia-deriv
maryia-deriv previously approved these changes Sep 6, 2023
View reviewed changes
markw-deriv
markw-deriv previously approved these changes Sep 6, 2023
View reviewed changes
@coveralls
Copy link

coveralls commented Sep 14, 2023

Coverage Status

coverage: 10.238% (+0.001%) from 10.237% when pulling 206865d on shaheer-deriv:shaheer/WALL-1420 into e042e20 on binary-com:master.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ali-hosseini-deriv ali-hosseini-deriv merged commit 7fe9dea into deriv-com:master Sep 22, 2023
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
@shaheer-deriv @vinu-deriv
feat: 🍄 updated PWA icon and color as per the latest branding (#9966)
f1a009a 
* fix: 🎨 updates PWA brand color

* fix: 📝 specifies app id explicitly instead of falling back to start url

* feat: 🔥 updates PWA icon to the latest deriv logo

* feat: 🎨 updates theme color in meta tag

* feat: ✨ adds varying size launcher entries

* feat: 📱 adds pwa icons to core package

* feat: 📱 adds pwa icons to cfd package

* feat: 📱 adds pwa icons to trader package

* feat: 📱 adds iOS pwa touch icon

* feat: 📱 adds iOS pwa touch icons for cfd package

* feat: 📱 adds pwa iOS touch icons for trader package
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
@shaheer-deriv @vinu-deriv
feat: 🍄 updated PWA icon and color as per the latest branding (#9966)
af8c6f1 
* fix: 🎨 updates PWA brand color

* fix: 📝 specifies app id explicitly instead of falling back to start url

* feat: 🔥 updates PWA icon to the latest deriv logo

* feat: 🎨 updates theme color in meta tag

* feat: ✨ adds varying size launcher entries

* feat: 📱 adds pwa icons to core package

* feat: 📱 adds pwa icons to cfd package

* feat: 📱 adds pwa icons to trader package

* feat: 📱 adds iOS pwa touch icon

* feat: 📱 adds iOS pwa touch icons for cfd package

* feat: 📱 adds pwa iOS touch icons for trader package
@shaheer-deriv shaheer-deriv deleted the shaheer/WALL-1420 branch January 18, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amina-deriv amina-deriv amina-deriv approved these changes

@shahzaib-deriv shahzaib-deriv shahzaib-deriv approved these changes

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@hirad-deriv hirad-deriv Awaiting requested review from hirad-deriv hirad-deriv is a code owner

+4 more reviewers

@suisin-deriv suisin-deriv suisin-deriv approved these changes

@yauheni-deriv yauheni-deriv yauheni-deriv approved these changes

@maryia-deriv maryia-deriv maryia-deriv left review comments

@markw-deriv markw-deriv markw-deriv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Core Trader

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@shaheer-deriv @coveralls @amina-deriv @suisin-deriv @maryia-deriv @yauheni-deriv @markw-deriv @shahzaib-deriv @ali-hosseini-deriv