Skip to content

Conversation

farabi-deriv
Copy link
Contributor

Changes:

Separated the bot stop click method that handles showing the snackbar notification

@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 6, 2023 8:57am

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9968](https://github.com/binary-com/deriv-app/pull/9968)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-703snackbar-s-730a8e.binary.sx?qa_server=red.binaryws.com&app_id=38788
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-703snackbar-s-730a8e.binary.sx
- **App ID**: `38788`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-703snackbar-s-730a8e.binary.sx/

@ali-hosseini-deriv ali-hosseini-deriv merged commit 118e4e0 into deriv-com:master Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants