Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dashing to 0.5.3; WIP #24230

Closed
wants to merge 2 commits into from
Closed

Update Dashing to 0.5.3; WIP #24230

wants to merge 2 commits into from

Conversation

dnbaker
Copy link

@dnbaker dnbaker commented Sep 3, 2020

I'm trying to update Dashing from 0.4.0 to 0.5.2. I don't know how to calculate the sha256 digest of a package being built from a git tag; this might break things, unfortunately. For this package, we're building from source so as to use the right vectorized instructions for a given machine.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@dnbaker dnbaker changed the title Update Dashing to 0.5.2; WIP Update Dashing to 0.5.3; WIP Sep 4, 2020
@dnbaker
Copy link
Author

dnbaker commented Sep 4, 2020

@SilasK Would you be willing to give me a hand?

I find that llvm-openmp isn't adding libomp.* for the clang compiler. (compilation fails with clang ld: library not found for -lomp) Requiring gcc, which would also solve the problem, on OSX causes bioconda to report an unsatisfiable requirement.

Do you have a recommendation for moving forward?

Daniel

@SilasK
Copy link
Member

SilasK commented Sep 4, 2020

Sorry, this is too complicated for me. Can someone else from @bioconda/core help?

@@ -11,21 +11,21 @@ build:
source:
git_url: https://github.com/dnbaker/dashing
git_rev: v{{ version }}
sha256: {{sha256}}
# sha256: {{sha256}} How is this found?
Copy link
Contributor

@bkille bkille Sep 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# sha256: {{sha256}} How is this found?
sha256: unused

I have not used git_url for packages in the past, but it seems like it is what most other contributors do. You may also need to add - missing_hash to your skip-lints: section.

@bkille
Copy link
Contributor

bkille commented Sep 19, 2020

SilasK Would you be willing to give me a hand?

I find that llvm-openmp isn't adding libomp.* for the clang compiler. (compilation fails with clang ld: library not found for -lomp) Requiring gcc, which would also solve the problem, on OSX causes bioconda to report an unsatisfiable requirement.

Do you have a recommendation for moving forward?

Daniel

The old version of one of our tools faced a similar issue when building on the bioconda containers. We were able to get successful linking by using the -fopenmp flag instead of -lomp. It seems that the more modern versions of clang support linking this way.

@dnbaker
Copy link
Author

dnbaker commented Sep 21, 2020

Fantastic. Thank you for the response! This should be the guidance I need to get the new package up and running.

I'll come back if I have any more questions.

@bernt-matthias
Copy link
Contributor

Now available in version 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants