Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CLI to click #631

Closed
ElDeveloper opened this issue Apr 24, 2015 · 13 comments
Closed

Move CLI to click #631

ElDeveloper opened this issue Apr 24, 2015 · 13 comments

Comments

@ElDeveloper
Copy link
Member

It would be awesome if the CLI could be moved to click, are there any current technical limitations?

@wasade
Copy link
Member

wasade commented Apr 24, 2015

No, just dev effort and agree. I think there might already be an open issue?

@ElDeveloper
Copy link
Member Author

Got it, couldn't find it, I only found mentions of click in the issues.

On (Apr-23-15|17:36), Daniel McDonald wrote:

No, just dev effort and agree. I think there might already be an open issue?


Reply to this email directly or view it on GitHub:
#631 (comment)

@wasade
Copy link
Member

wasade commented Apr 24, 2015

ah, well you take the 🍰 :)

@josenavas
Copy link
Member

If we move the CLI to click means that is a major release? Just checking cause it think I won't be backwards compatible, or am I missing something?

@wasade
Copy link
Member

wasade commented Apr 24, 2015

yes

On Thu, Apr 23, 2015 at 8:44 PM, josenavas notifications@github.com wrote:

If we move the CLI to click means that is a major release? Just checking
cause I think I won't be backwards compatible, or am I missing something?


Reply to this email directly or view it on GitHub
#631 (comment).

@ElDeveloper
Copy link
Member Author

3.0, here we go!

On (Apr-23-15|19:49), Daniel McDonald wrote:

yes

On Thu, Apr 23, 2015 at 8:44 PM, josenavas notifications@github.com wrote:

If we move the CLI to click means that is a major release? Just checking
cause I think I won't be backwards compatible, or am I missing something?


Reply to this email directly or view it on GitHub
#631 (comment).


Reply to this email directly or view it on GitHub:
#631 (comment)

@wasade
Copy link
Member

wasade commented Apr 24, 2015

we could do a minor release i suppose

On Thu, Apr 23, 2015 at 8:51 PM, Yoshiki Vázquez Baeza <
notifications@github.com> wrote:

3.0, here we go!

On (Apr-23-15|19:49), Daniel McDonald wrote:

yes

On Thu, Apr 23, 2015 at 8:44 PM, josenavas notifications@github.com
wrote:

If we move the CLI to click means that is a major release? Just
checking
cause I think I won't be backwards compatible, or am I missing
something?


Reply to this email directly or view it on GitHub
<
https://github.com/biocore/biom-format/issues/631#issuecomment-95780259>.


Reply to this email directly or view it on GitHub:
#631 (comment)


Reply to this email directly or view it on GitHub
#631 (comment).

@gregcaporaso
Copy link
Contributor

Just remember that backward compatibility is needed for biom-format >= 2.1.3, < 2.2.0 - that's what QIIME depends on.

@wasade
Copy link
Member

wasade commented Apr 24, 2015

Ya, so I was thinking 2.2 instead of 3.0

On Thu, Apr 23, 2015 at 9:15 PM, Greg Caporaso notifications@github.com
wrote:

Just remember that backward compatibility is needed for biom-format >=
2.1.3, < 2.2.0 - that's what QIIME depends on.


Reply to this email directly or view it on GitHub
#631 (comment).

@gregcaporaso
Copy link
Contributor

Ok, perfect.

@ebolyen
Copy link
Member

ebolyen commented Oct 19, 2015

  • add-metadata Add metadata to a BIOM table (@gregcaporaso) - note that failure to write biom table with latest version #530 has been present since 2.1.3, and it's still present
  • convert Convert to/from the BIOM table format (@gregcaporaso)
    • adding observation metadata doesn't work, but it seems like it didn't work in 2.1.4 either (and maybe we don't need to fix this, b/c that's what add-metadata is for)
    • add unit tests
    • test the examples listed on the web biom docs
  • normalize-table Normalize a BIOM table (@wasade)
  • show-install-info Provide information about the biom-format installation (@jairideout)
  • subset-table Subset a BIOM table (@jairideout)
  • summarize-table Summarize sample or observation data in a BIOM table (@ebolyen)
  • validate-table Validate a BIOM-formatted file (@ebolyen)
  • head
    from-uc (@gregcaporaso or @jairideout)

@wasade wasade mentioned this issue Oct 19, 2015
@jairideout jairideout mentioned this issue Oct 19, 2015
gregcaporaso added a commit to gregcaporaso/biom-format that referenced this issue Oct 19, 2015
@gregcaporaso
Copy link
Contributor

I've tested all of the commands presented on the website, and they're working as they did in 2.1.4. Closing this.

@ElDeveloper
Copy link
Member Author

🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants