Port edge cases from skbio #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Real: https://travis-ci.org/biocore/unifrac/jobs/273071166#L1034 Also, i thought we were going to remove the minimal and add after this merge? |
wasade
reviewed
Sep 8, 2017
q2_state_unifrac/tests/test_api.py
Outdated
| # | ||
| # The test cases below only exercise unweighted, weighted and weighted | ||
| # normalized UniFrac. Testing against reference implementations for the | ||
| # variance adjusted and gain variants are performed in the C++ test suite. |
There was a problem hiding this comment.
"variance adjusted and gain variants" -> "variance adjusted and generalized unifrac"
|
Just one comment, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all tests were ported, but the appropriate issues have been opened, see: #34, #35 and #36.