Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relationship_type argument to GolrAssociationQuery #212

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

deepakunni3
Copy link
Member

Fix for monarch-initiative/biolink-api#201

Adding the flexibility of selecting a closure depending on a given relationship_type

Copy link
Contributor

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

In future iterations of our golr schema, we should simply name the closure fields for entity and association docs according to the gp2term relationship. The current schema is based on
an early mistaken desire by me to "reuse" fields across golr-views.

In other words, isapartof_closure would be for GO ontology docs (since is_a and part_of are relations that hold e.g. between two processes), and involved_in and causally_upstream_of_or_within would be in assoc docs (since this holds between gp and a term) (cc @kltm and @balhoff )

This would obviate the need for a confusing mapping, where we say "for involved in use the isapartof closure" etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants