Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(useNamingConvention): add examples and improve explanations #3277

Merged
merged 2 commits into from
Jun 24, 2024
Merged

docs(useNamingConvention): add examples and improve explanations #3277

merged 2 commits into from
Jun 24, 2024

Conversation

Conaclos
Copy link
Member

Summary

Take feedbacks into account.

Test Plan

CI must pass.

@Conaclos Conaclos marked this pull request as ready for review June 24, 2024 11:01
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jun 24, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 24, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3277 will not alter performance

Comparing conaclos/useNamingConvention/improve-docs (6aba917) with main (0c253b6)

Summary

✅ 90 untouched benchmarks

ematipico
ematipico reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few grammar nits.

crates/biome_js_analyze/src/lint/style/use_naming_convention.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/src/lint/style/use_naming_convention.rs Outdated Show resolved Hide resolved
crates/biome_js_analyze/src/lint/style/use_naming_convention.rs Outdated Show resolved Hide resolved
@Conaclos @ematipico
Apply suggestions from code review
6aba917 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
wojtekmaj
wojtekmaj approved these changes Jun 24, 2024
View reviewed changes
Copy link

@wojtekmaj wojtekmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the changes and I especially appreciate the examples.

@Conaclos Conaclos merged commit a3c2b18 into main Jun 24, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/useNamingConvention/improve-docs branch June 24, 2024 14:55
@ramzimalhas ramzimalhas mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 28, 2024
Open
Open
@Ramyromel Ramyromel mentioned this pull request Sep 9, 2024
Open
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
@Ramyromel Ramyromel mentioned this pull request Sep 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtekmaj wojtekmaj wojtekmaj approved these changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Conaclos @ematipico @wojtekmaj