New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added favicon #178
Added favicon #178
Conversation
Fixed biopython#86
Could you update |
I updated |
Was it deliberate to rename |
After your comment I read about this on developer.apple.com. According to them it is enough to keep the file as The problem is with the resolution of image, maximum resolution is |
As far as I have understood it is practice now to provide several favicon.png files with different resolutions: So you can decide to put something like 7-... different sized favicons to support an optimal look on each plattform/browser or to put something like 3 files, one being a 32x32 png, one being an high-resolution apple-touch icon and possibly a high-resolution png. |
@MarkusPiotrowski idea of adding multiple images looks good. The problem I pointed out in this comment can be fixed by applying an image with transparent background. I am thinking to add html markup and images generated by realfavicongenerator.net. This will automatically add images for different devices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but I am not up to date with best practises here. Over to @MarkusPiotrowski or @JoaoRodrigues to second and/or merge.
@JoaoRodrigues and @MarkusPiotrowski would you like to review this? |
I have merged the changes to my local branch and pushed it here: As far as I can tell it looks good on Windows 10 in Firefox and Edge browser but not so nice as tile (because the tile background is also blue). Actually, this was the first time that I added a webpage as "app" on Windows, so I think this is a very rare scenario and we can live with that. |
Tiny tab/bookmark icon looks good on macOS Chrome, Firefox and Safari. Home screen icon looks good on iPhone. |
@LalitNM Good work, thank you! |
@peterjc, @JoaoRodrigues and @MarkusPiotrowski
Have a look at this pull request and let me know if something else can be merged with this pull request(e.g. removing apple-touch-icon-144.png
This fixes #86.