Removed FactoryBean interface as it does not make sense any more. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FactoryBean interface was used back in the days when we were total XML configuration addicts. These days with the pure PHP configuration there is no need to maintain this piece of history any more.
|
In a next step we should get rid of the initializeBean() method and "copy" the method body into the generated bean methods to get rid of the additional method call. |
… the BeanMethod generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FactoryBean interface was used back in the days when we were total
XML configuration addicts. These days with the pure PHP configuration
there is no need to maintain this piece of history any more.
See the discussion in this (PR)[https://github.com//pull/40] for reference.