Fix bitcoin-qt visual glitches on Wayland #904
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
1 task
hebasto
reviewed
Oct 16, 2025
hebasto
reviewed
Oct 16, 2025
diegoviola
force-pushed
the
fix-qt-wayland-rendering-issue
branch
2 times, most recently
from
0fcab7d to
5535da8
Compare
diegoviola
force-pushed
the
fix-qt-wayland-rendering-issue
branch
from
5535da8 to
76e4b71
Compare
There was a problem hiding this comment.
Concept ACK
If you can, please check how this behaves on #817.
diegoviola
added a commit
to diegoviola/gui
that referenced
this pull request
Oct 18, 2025
The main window (BitcoinGUI) does not need to be passed to bringToFront(), doing so sets Qt::WindowStaysOnTopHint on the main window and causes it to flicker. Fixes bitcoin-core#904 and bitcoin/bitcoin#33432.
diegoviola
force-pushed
the
fix-qt-wayland-rendering-issue
branch
from
76e4b71 to
6542d5f
Compare
diegoviola
added a commit
to diegoviola/gui
that referenced
this pull request
Oct 18, 2025
The main window (BitcoinGUI) does not need to be passed to bringToFront(), doing so sets Qt::WindowStaysOnTopHint on the main window and causes it to flicker. Fixes bitcoin-core#904 and bitcoin/bitcoin#33432.
diegoviola
force-pushed
the
fix-qt-wayland-rendering-issue
branch
from
6542d5f to
949e953
Compare
|
@pablomartin4btc can you please re-review? |
diegoviola
force-pushed
the
fix-qt-wayland-rendering-issue
branch
2 times, most recently
from
6f71ab2 to
50f4b19
Compare
The main window (BitcoinGUI) does not need to be passed to bringToFront(), doing so sets Qt::WindowStaysOnTopHint on the main window and causes it to flicker. Fixes bitcoin-core#903.
diegoviola
force-pushed
the
fix-qt-wayland-rendering-issue
branch
from
50f4b19 to
095f920
Compare
diegoviola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main window (BitcoinGUI) does not need to be passed to bringToFront(), doing so sets Qt::WindowStaysOnTopHint on the main window and causes it to flicker.
Fixes #903.