BIP174: Specify PSBT_IN_PREVIOUS_TXID serialization order #2001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murchandamus
changed the title
murchandamus
added
Proposed BIP modification
Pending acceptance
|
cc: @achow101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates descriptions for the
PSBT_IN_PREVIOUS_TXIDfield to specify serialization order.It was not straightforward the order with which to store the txid in a psbt. It's not clearly specified in the spec, and there are not many resources or parsers to aid in debugging PSBTv2. I found the BIP370 test vector "Case: PSBTv0 but with PSBT_IN_PREVIOUS_TXID." seems to imply that the order of this txid value in
PSBT_IN_PREVIOUS_TXIDshould match network serialization order.I'm torn on if "little endian" is the correct phrase to use here in conjunction with "txid". I usually think of a "txid" as the big endian, human-presented order of a txn hash, but maybe it's okay to use interchangeably.