Skip to content

Commit

Permalink
Merge #12542: Remove redundant includes. Conform to header include gu…
Browse files Browse the repository at this point in the history
…idelines.

7ef46d0 Remove redundant includes. Conform to header include guidelines. (practicalswift)

Pull request description:

  From the header include guidelines ([developer-notes.md](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#source-code-organization)):

  > "One exception is that a `.cpp` file does not need to re-include the includes already included in its corresponding `.h` file."

  Covered in this PR:
  * `rpc/util.h` includes `pubkey.h` + `utilstrencodings.h`. `rpc/util.cpp` includes `rpc/util.h`.
  * `util.h` includes `fs.h`. `util.cpp` includes `util.h`.

Tree-SHA512: a38d9ecefd8165ad151c1ffde52cfbac968526c49db2080988bf6e6a3daa2ebeceb34d08f817e275edf7c650bf3155de01369bfb352522f8e0ae136b2289b194
  • Loading branch information
sipa committed Mar 16, 2018
2 parents 7be9a9a + 7ef46d0 commit af20f9b
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/rpc/util.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

#include <key_io.h>
#include <keystore.h>
#include <pubkey.h>
#include <rpc/protocol.h>
#include <rpc/util.h>
#include <tinyformat.h>
Expand Down
1 change: 0 additions & 1 deletion src/rpc/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <pubkey.h>
#include <script/standard.h>
#include <univalue.h>
#include <utilstrencodings.h>

#include <boost/variant/static_visitor.hpp>

Expand Down
1 change: 0 additions & 1 deletion src/util.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
// file COPYING or http://www.opensource.org/licenses/mit-license.php.

#include <util.h>
#include <fs.h>

#include <chainparamsbase.h>
#include <random.h>
Expand Down

0 comments on commit af20f9b

Please sign in to comment.