Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitcoin-Qt: Label use non-intuitive to newbies: appears to be per-transaction rather than per-address #1168

Closed
luke-jr opened this issue Apr 30, 2012 · 6 comments
Closed

Bitcoin-Qt: Label use non-intuitive to newbies: appears to be per-transaction rather than per-address #1168

luke-jr opened this issue Apr 30, 2012 · 6 comments
Labels
Feature GUI

Comments

@luke-jr
Copy link
Member

luke-jr commented Apr 30, 2012

See 3 posts on the subject at https://bitcointalk.org/?topic=78301.msg873713#msg873713
@gavinandresen
Copy link
Contributor

I'd vote to fix this by implementing per-transaction comments.

@laanwj
Copy link
Member

laanwj commented Apr 30, 2012

If you use a address per transaction, as recommended, they are per-address.

Per-transaction comments would be a useful addition, though we have to be careful that people don't confuse them for messages that are sent with transactions... and then being surprised that the recipient doesn't see the comment.

@luke-jr
Copy link
Member Author

luke-jr commented Apr 30, 2012

I think transaction-tied signed messages would be handy. Let people add them in addition to recipients, and then display the signatures out-of-band after sent (and let them view them again later by double-clicking the txn).

@laanwj laanwj mentioned this issue May 24, 2012
Closed
@jonasschnelli
Copy link
Contributor

Related to #5905 and #2086

@laanwj laanwj added Feature and removed Refactoring labels Feb 9, 2016
@Sjors Sjors mentioned this issue Nov 22, 2017
Merged
dexX7 added a commit to dexX7/bitcoin that referenced this issue Sep 23, 2020
@dexX7
Merge bitcoin#1168: Support adding a receiver address for "any data" …
686077c 
…transactions

27f30e7 Support adding a receiver address for "any data" transactions (dexX7)

Pull request description:

  The new transaction 200 now supports also an optional receiver address.

  ### Example: No receiver specified

  ```
  omni_sendanydata "2MsKdZp2EztZZXv3P17dmjEt9VUdb698wiL" "0101"
  ```
  ```
  fdc754f8f4931412f8398ff76e518cc29d403acddf995a9f5efb5c98451c9ee9
  ```

  ```
  omni_gettransaction "fdc754f8f4931412f8398ff76e518cc29d403acddf995a9f5efb5c98451c9ee9"
  ```
  ```
  {
    "txid": "fdc754f8f4931412f8398ff76e518cc29d403acddf995a9f5efb5c98451c9ee9",
    "fee": "0.00003100",
    "sendingaddress": "2MsKdZp2EztZZXv3P17dmjEt9VUdb698wiL",
    "referenceaddress": "2MsKdZp2EztZZXv3P17dmjEt9VUdb698wiL", # <-- with no receiver given, receiver = sender
    "ismine": true,
    "version": 0,
    "type_int": 200,
    "type": "Embed any data",
    "data": "0101",
    "confirmations": 0
  }
  ```

  ### Example: One receiver specified

  ```
  omni_sendanydata "2MsKdZp2EztZZXv3P17dmjEt9VUdb698wiL" "0202" "2N85ZZpYLqEvTRbuVzFzfXMRWqxbQm3v46Q"
  ```
  ```
  b259dba9dcedecfb095a00f1540a09fcffc0fc3d5863c5a408d206886a24d2d9
  ```

  ```
  omni_gettransaction "b259dba9dcedecfb095a00f1540a09fcffc0fc3d5863c5a408d206886a24d2d9"
  ```
  ```
  {
    "txid": "b259dba9dcedecfb095a00f1540a09fcffc0fc3d5863c5a408d206886a24d2d9",
    "fee": "0.00003740",
    "sendingaddress": "2MsKdZp2EztZZXv3P17dmjEt9VUdb698wiL",
    "referenceaddress": "2N85ZZpYLqEvTRbuVzFzfXMRWqxbQm3v46Q", # <-- the specified receiver
    "ismine": true,
    "version": 0,
    "type_int": 200,
    "type": "Embed any data",
    "data": "0202",
    "confirmations": 0
  }
  ```

Tree-SHA512: bb37e3efb2bfe4507573ee89acca0d03a0f9f67dc45b35a506b7f8ef362bbbdda2473f5673f012b87d75e4f3bd555551398bd2f2a49b395be70fd8213196dace
This was referenced Feb 18, 2021
Closed
Merged
maflcko pushed a commit to bitcoin-core/gui that referenced this issue Feb 22, 2021
Merge #211: qt: Remove Transactionview Edit Label Action
5e4a3ca 
8f96448 qt: Remove Transactionview Edit Label Action (Jarol Rodriguez)

Pull request description:

  This PR removes the `Edit Label` action from the `transactionview` context menu. Since the `Edit Label` action will no longer be utilized in the `transactionview`, the `Edit Label` function logic is also removed.

  | Master        |        PR        |
  | ----------- | ----------- |
  |<img width="248" alt="Screen Shot 2021-02-17 at 8 34 34 PM" src="https://user-images.githubusercontent.com/23396902/108292189-9b86c800-7161-11eb-9e80-6238523bc27e.png">|<img width="248" alt="Screen Shot 2021-02-17 at 8 35 10 PM" src="https://user-images.githubusercontent.com/23396902/108292204-a17ca900-7161-11eb-8582-7f33d3e2ba8f.png">|

  Among the context menu actions for each transaction in the `transactionview` is the `Edit Label` action.
  While all other actions apply directly to the selected transaction, the `Edit Label` action applies to the selected transaction's address. As documented in issue #209 and [#1168](bitcoin/bitcoin#1168) , this is an "unfortunate" placement for such an action. The current placement creates a confusing UX scenario where the outcome of the action is ambiguous.

  **Example of Ambiguous Behavior:**
  The context menu gives the wrong impression that the `Edit Label` action will edit a `Label` for the specific transaction that has been right-clicked on. This impression can be because all other actions in this menu will relate to the specific transaction and the misconception between `Comment` and `Label`.
  <img width="1062" alt="editlabel-start" src="https://user-images.githubusercontent.com/23396902/108296385-6da48200-7167-11eb-89f0-b21ccc58f6f4.png">

  Let's say I wanted to give the transaction selected in the screenshot above a comment of "2-17[17:43]". Given all the context clues, it will be reasonable to assume that the `Edit Label` function will give a label to this transaction. Instead, it edits the `Label` for the address behind this transaction. Thus, changing the `Label` for all transactions associated with this address.
  <img width="971" alt="editlabel-end" src="https://user-images.githubusercontent.com/23396902/108297179-e35d1d80-7168-11eb-86a9-0d2796c51829.png">

  **Maintaining `Edit Label` Functionality:**
  The action of Editing a Label should instead be reserved for the respective address tables of the `Send` and `Receive` tabs. As documented in this [comment](#209 (comment)), `Edit Label` is currently implemented in the `Send` tab and is missing in the `Receive` tab. A follow-up PR can add the `Edit Label` functionality to the `Receive` tab.

ACKs for top commit:
  MarcoFalke:
    review ACK 8f96448
  Talkless:
    tACK 8f96448, tested on Debian Sid.

Tree-SHA512: 70bbcc8be3364b0d4f476a9760aa14ad1ad1f53b0b130ce0ffe75190d76c386e6e26c530c0a55d1742402fe2b45c68a2af6dbfaf58ee9909ad93b06f0b6559d4
sidhujag pushed a commit to syscoin/syscoin that referenced this issue Feb 22, 2021
Merge bitcoin-core/gui#211: qt: Remove Transactionview Edit Label Action
cf2b290 
8f96448 qt: Remove Transactionview Edit Label Action (Jarol Rodriguez)

Pull request description:

  This PR removes the `Edit Label` action from the `transactionview` context menu. Since the `Edit Label` action will no longer be utilized in the `transactionview`, the `Edit Label` function logic is also removed.

  | Master        |        PR        |
  | ----------- | ----------- |
  |<img width="248" alt="Screen Shot 2021-02-17 at 8 34 34 PM" src="https://user-images.githubusercontent.com/23396902/108292189-9b86c800-7161-11eb-9e80-6238523bc27e.png">|<img width="248" alt="Screen Shot 2021-02-17 at 8 35 10 PM" src="https://user-images.githubusercontent.com/23396902/108292204-a17ca900-7161-11eb-8582-7f33d3e2ba8f.png">|

  Among the context menu actions for each transaction in the `transactionview` is the `Edit Label` action.
  While all other actions apply directly to the selected transaction, the `Edit Label` action applies to the selected transaction's address. As documented in issue #209 and [bitcoin#1168](bitcoin#1168) , this is an "unfortunate" placement for such an action. The current placement creates a confusing UX scenario where the outcome of the action is ambiguous.

  **Example of Ambiguous Behavior:**
  The context menu gives the wrong impression that the `Edit Label` action will edit a `Label` for the specific transaction that has been right-clicked on. This impression can be because all other actions in this menu will relate to the specific transaction and the misconception between `Comment` and `Label`.
  <img width="1062" alt="editlabel-start" src="https://user-images.githubusercontent.com/23396902/108296385-6da48200-7167-11eb-89f0-b21ccc58f6f4.png">

  Let's say I wanted to give the transaction selected in the screenshot above a comment of "2-17[17:43]". Given all the context clues, it will be reasonable to assume that the `Edit Label` function will give a label to this transaction. Instead, it edits the `Label` for the address behind this transaction. Thus, changing the `Label` for all transactions associated with this address.
  <img width="971" alt="editlabel-end" src="https://user-images.githubusercontent.com/23396902/108297179-e35d1d80-7168-11eb-86a9-0d2796c51829.png">

  **Maintaining `Edit Label` Functionality:**
  The action of Editing a Label should instead be reserved for the respective address tables of the `Send` and `Receive` tabs. As documented in this [comment](bitcoin-core/gui#209 (comment)), `Edit Label` is currently implemented in the `Send` tab and is missing in the `Receive` tab. A follow-up PR can add the `Edit Label` functionality to the `Receive` tab.

ACKs for top commit:
  MarcoFalke:
    review ACK 8f96448
  Talkless:
    tACK 8f96448, tested on Debian Sid.

Tree-SHA512: 70bbcc8be3364b0d4f476a9760aa14ad1ad1f53b0b130ce0ffe75190d76c386e6e26c530c0a55d1742402fe2b45c68a2af6dbfaf58ee9909ad93b06f0b6559d4
@jarolrod
Copy link
Member

jarolrod commented Feb 24, 2021 •
edited
Loading

These are the steps I believe should be taken to close this:

  • Remove Edit Label in Transaction View
    • PR #211 removed the ability to Edit Label in the Transaction View. The removal of this feature will prevent confusion that you are editing a unique identifier for that transaction.
  • Add ability to add a comment to a Transaction (this would be local on the machine)

@luke-jr
Copy link
Member Author

luke-jr commented Feb 24, 2021

This issue shouldn't be fixed (gui#211 should be reverted). Per-transaction is per-address.

@luke-jr luke-jr closed this as completed Feb 24, 2021
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Sep 17, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#211: qt: Remove Transactionview Edit Label Action
fdc34f6 
8f96448 qt: Remove Transactionview Edit Label Action (Jarol Rodriguez)

Pull request description:

  This PR removes the `Edit Label` action from the `transactionview` context menu. Since the `Edit Label` action will no longer be utilized in the `transactionview`, the `Edit Label` function logic is also removed.

  | Master        |        PR        |
  | ----------- | ----------- |
  |<img width="248" alt="Screen Shot 2021-02-17 at 8 34 34 PM" src="https://user-images.githubusercontent.com/23396902/108292189-9b86c800-7161-11eb-9e80-6238523bc27e.png">|<img width="248" alt="Screen Shot 2021-02-17 at 8 35 10 PM" src="https://user-images.githubusercontent.com/23396902/108292204-a17ca900-7161-11eb-8582-7f33d3e2ba8f.png">|

  Among the context menu actions for each transaction in the `transactionview` is the `Edit Label` action.
  While all other actions apply directly to the selected transaction, the `Edit Label` action applies to the selected transaction's address. As documented in issue dashpay#209 and [dashpay#1168](bitcoin#1168) , this is an "unfortunate" placement for such an action. The current placement creates a confusing UX scenario where the outcome of the action is ambiguous.

  **Example of Ambiguous Behavior:**
  The context menu gives the wrong impression that the `Edit Label` action will edit a `Label` for the specific transaction that has been right-clicked on. This impression can be because all other actions in this menu will relate to the specific transaction and the misconception between `Comment` and `Label`.
  <img width="1062" alt="editlabel-start" src="https://user-images.githubusercontent.com/23396902/108296385-6da48200-7167-11eb-89f0-b21ccc58f6f4.png">

  Let's say I wanted to give the transaction selected in the screenshot above a comment of "2-17[17:43]". Given all the context clues, it will be reasonable to assume that the `Edit Label` function will give a label to this transaction. Instead, it edits the `Label` for the address behind this transaction. Thus, changing the `Label` for all transactions associated with this address.
  <img width="971" alt="editlabel-end" src="https://user-images.githubusercontent.com/23396902/108297179-e35d1d80-7168-11eb-86a9-0d2796c51829.png">

  **Maintaining `Edit Label` Functionality:**
  The action of Editing a Label should instead be reserved for the respective address tables of the `Send` and `Receive` tabs. As documented in this [comment](bitcoin-core/gui#209 (comment)), `Edit Label` is currently implemented in the `Send` tab and is missing in the `Receive` tab. A follow-up PR can add the `Edit Label` functionality to the `Receive` tab.

ACKs for top commit:
  MarcoFalke:
    review ACK 8f96448
  Talkless:
    tACK 8f96448, tested on Debian Sid.

Tree-SHA512: 70bbcc8be3364b0d4f476a9760aa14ad1ad1f53b0b130ce0ffe75190d76c386e6e26c530c0a55d1742402fe2b45c68a2af6dbfaf58ee9909ad93b06f0b6559d4
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Sep 19, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#211: qt: Remove Transactionview Edit Label Action
d3fc1a5 
8f96448 qt: Remove Transactionview Edit Label Action (Jarol Rodriguez)

Pull request description:

  This PR removes the `Edit Label` action from the `transactionview` context menu. Since the `Edit Label` action will no longer be utilized in the `transactionview`, the `Edit Label` function logic is also removed.

  | Master        |        PR        |
  | ----------- | ----------- |
  |<img width="248" alt="Screen Shot 2021-02-17 at 8 34 34 PM" src="https://user-images.githubusercontent.com/23396902/108292189-9b86c800-7161-11eb-9e80-6238523bc27e.png">|<img width="248" alt="Screen Shot 2021-02-17 at 8 35 10 PM" src="https://user-images.githubusercontent.com/23396902/108292204-a17ca900-7161-11eb-8582-7f33d3e2ba8f.png">|

  Among the context menu actions for each transaction in the `transactionview` is the `Edit Label` action.
  While all other actions apply directly to the selected transaction, the `Edit Label` action applies to the selected transaction's address. As documented in issue dashpay#209 and [dashpay#1168](bitcoin#1168) , this is an "unfortunate" placement for such an action. The current placement creates a confusing UX scenario where the outcome of the action is ambiguous.

  **Example of Ambiguous Behavior:**
  The context menu gives the wrong impression that the `Edit Label` action will edit a `Label` for the specific transaction that has been right-clicked on. This impression can be because all other actions in this menu will relate to the specific transaction and the misconception between `Comment` and `Label`.
  <img width="1062" alt="editlabel-start" src="https://user-images.githubusercontent.com/23396902/108296385-6da48200-7167-11eb-89f0-b21ccc58f6f4.png">

  Let's say I wanted to give the transaction selected in the screenshot above a comment of "2-17[17:43]". Given all the context clues, it will be reasonable to assume that the `Edit Label` function will give a label to this transaction. Instead, it edits the `Label` for the address behind this transaction. Thus, changing the `Label` for all transactions associated with this address.
  <img width="971" alt="editlabel-end" src="https://user-images.githubusercontent.com/23396902/108297179-e35d1d80-7168-11eb-86a9-0d2796c51829.png">

  **Maintaining `Edit Label` Functionality:**
  The action of Editing a Label should instead be reserved for the respective address tables of the `Send` and `Receive` tabs. As documented in this [comment](bitcoin-core/gui#209 (comment)), `Edit Label` is currently implemented in the `Send` tab and is missing in the `Receive` tab. A follow-up PR can add the `Edit Label` functionality to the `Receive` tab.

ACKs for top commit:
  MarcoFalke:
    review ACK 8f96448
  Talkless:
    tACK 8f96448, tested on Debian Sid.

Tree-SHA512: 70bbcc8be3364b0d4f476a9760aa14ad1ad1f53b0b130ce0ffe75190d76c386e6e26c530c0a55d1742402fe2b45c68a2af6dbfaf58ee9909ad93b06f0b6559d4
thelazier pushed a commit to thelazier/dash that referenced this issue Sep 25, 2021
@thelazier
Merge bitcoin-core/gui#211: qt: Remove Transactionview Edit Label Action
afd8d63 
8f96448 qt: Remove Transactionview Edit Label Action (Jarol Rodriguez)

Pull request description:

  This PR removes the `Edit Label` action from the `transactionview` context menu. Since the `Edit Label` action will no longer be utilized in the `transactionview`, the `Edit Label` function logic is also removed.

  | Master        |        PR        |
  | ----------- | ----------- |
  |<img width="248" alt="Screen Shot 2021-02-17 at 8 34 34 PM" src="https://user-images.githubusercontent.com/23396902/108292189-9b86c800-7161-11eb-9e80-6238523bc27e.png">|<img width="248" alt="Screen Shot 2021-02-17 at 8 35 10 PM" src="https://user-images.githubusercontent.com/23396902/108292204-a17ca900-7161-11eb-8582-7f33d3e2ba8f.png">|

  Among the context menu actions for each transaction in the `transactionview` is the `Edit Label` action.
  While all other actions apply directly to the selected transaction, the `Edit Label` action applies to the selected transaction's address. As documented in issue dashpay#209 and [dashpay#1168](bitcoin#1168) , this is an "unfortunate" placement for such an action. The current placement creates a confusing UX scenario where the outcome of the action is ambiguous.

  **Example of Ambiguous Behavior:**
  The context menu gives the wrong impression that the `Edit Label` action will edit a `Label` for the specific transaction that has been right-clicked on. This impression can be because all other actions in this menu will relate to the specific transaction and the misconception between `Comment` and `Label`.
  <img width="1062" alt="editlabel-start" src="https://user-images.githubusercontent.com/23396902/108296385-6da48200-7167-11eb-89f0-b21ccc58f6f4.png">

  Let's say I wanted to give the transaction selected in the screenshot above a comment of "2-17[17:43]". Given all the context clues, it will be reasonable to assume that the `Edit Label` function will give a label to this transaction. Instead, it edits the `Label` for the address behind this transaction. Thus, changing the `Label` for all transactions associated with this address.
  <img width="971" alt="editlabel-end" src="https://user-images.githubusercontent.com/23396902/108297179-e35d1d80-7168-11eb-86a9-0d2796c51829.png">

  **Maintaining `Edit Label` Functionality:**
  The action of Editing a Label should instead be reserved for the respective address tables of the `Send` and `Receive` tabs. As documented in this [comment](bitcoin-core/gui#209 (comment)), `Edit Label` is currently implemented in the `Send` tab and is missing in the `Receive` tab. A follow-up PR can add the `Edit Label` functionality to the `Receive` tab.

ACKs for top commit:
  MarcoFalke:
    review ACK 8f96448
  Talkless:
    tACK 8f96448, tested on Debian Sid.

Tree-SHA512: 70bbcc8be3364b0d4f476a9760aa14ad1ad1f53b0b130ce0ffe75190d76c386e6e26c530c0a55d1742402fe2b45c68a2af6dbfaf58ee9909ad93b06f0b6559d4
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Feature GUI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@laanwj @jonasschnelli @gavinandresen @luke-jr @jarolrod