Confirmations not appearing for sent coins after recovering wallet from archive

[sgornick]

I was able to recreate an issue where after sending bitcoins and then restoring the wallet the transaction never shows any confirmations even though the transaction did make it to the recipient and does appear in BlockExplorer.

The steps I performed were:
1.) Create a new wallet
2.) Requested a new address
3.) Received some seed bitcoins (two transactions) to that new address.
4.) Made an archive of my wallet.
5.) Sent two test payment transactions. (to 16W7FAZ8tcX1gDLgDupfAKfpGLYd7XcPRe a 0.02 BTC and a 0.03 BTC)
6.) Recover wallet from archive.

After many blocks passed (more than an hour), the confirmations still shows 0/unconfirmed. To confirm that the payment was sent, I confirmed:
http://blockexplorer.com/address/16W7FAZ8tcX1gDLgDupfAKfpGLYd7XcPRe

To try to get a clean load of blocks, I then purged the blk*.dat, __db*, addr.dat, .log and database/ (i.e., all files except wallet.dat) and started bitcoin again.
$ bitcoin -datadir=.

After letting the client catch up to the most recent block, ... and then waiting at least an hour further, my two test transactions still show 0/unconfirmed.

The test wallet (with 0 BTC balance) that can be used to recreate this issue is at:
http://c1958612.cdn.cloudfiles.rackspacecloud.com/wallet.dat

[gavinandresen]

This may be caused by the same bug as the "sum(accounts) != getbalance" bug.

[gavinandresen]

This is related the the other bug.
They are both symptoms of having a wallet with private keys in it that the bitcoin client thinks haven't been used yet, but that actually were used.

I just committed a new command-line flag: -rescan ... that scans all previous transactions, looking for any that match private keys in the wallet. Running the test wallet with -rescan Does the Right Thing:

listtransactions '*'
[
{
    "account" : "",
    "address" : "1CuUymfzaqgLm3c9YoN9fUK7Uyk6ZiGipG",
    "category" : "receive",
    "amount" : 0.03000000,
    "confirmations" : 1795,
    "txid" : "04299797da34d01ea8f000be656535cea16ca0aa1f385f416b1c3f11811d1f6f",
    "time" : 1294647952
},
{
    "account" : "",
    "address" : "1CuUymfzaqgLm3c9YoN9fUK7Uyk6ZiGipG",
    "category" : "receive",
    "amount" : 0.02000000,
    "confirmations" : 1795,
    "txid" : "585cb6493aa6b67364d6816062248d51b33738a28675ac70f4eb2daaad1433d0",
    "time" : 1294647952
},
{
    "account" : "",
    "address" : "16W7FAZ8tcX1gDLgDupfAKfpGLYd7XcPRe",
    "category" : "send",
    "amount" : -0.05000000,
    "fee" : 0.00000000,
    "confirmations" : 1792,
    "txid" : "3d1c7534d993629bb43c9676abb9250f01bd006bf272f39337a1cb29b1eb9d37",
    "time" : 1294649139
}
]