Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setaccount / getaccountaddress not working properly #29

Closed
tcatm opened this issue Jan 13, 2011 · 1 comment
Closed

setaccount / getaccountaddress not working properly #29

tcatm opened this issue Jan 13, 2011 · 1 comment
Labels
Bug

Comments

@tcatm
Copy link

tcatm commented Jan 13, 2011

When creating a new account with getaccountaddress, assigning that address to another account and then getting a new address from getaccountaddress still returns the old address (thus not creating a new account).

Steps to reproduce:
getaccountaddress "foo"
returns: xyz123
setaccountaddress "xyz123" ""
getaccountaddress "foo"
returns: xyz123
@gavinandresen
Copy link
Contributor

Fixed: 1aefe49

nelisky pushed a commit to nelisky/bitcoin that referenced this issue Apr 4, 2013
[build] boost,dep,fix: boost >= 1.0.50 build fix
051628c 
 - reported by ramccor  ; boost >= 1.0.50 now uses TIME_UTC_ instead of

   TIME_UTC
 - for reference: The change TIME_UTC_ was motivated by https://svn.boost.org/trac/boost/ticket/6940 TIME_UTC is a macro in C11.

 - closes issue bitcoin#29
zathras-crypto referenced this issue in zathras-crypto/omnicore Jun 26, 2014
@m21
Merge pull request #29 from wanderingbort/boost-filename-compat
d50e136 
backwards compatibility for boost::filesystem v2
dexX7 pushed a commit to dexX7/bitcoin that referenced this issue Feb 21, 2015
@zathras-crypto
Merge pull request bitcoin#29 from dexX7/mcore-0.0.9-zathras-ui-state…
d93d80e 
…-signals

QT: respond to state change signal in all tabs
@rustyrussell rustyrussell mentioned this issue Mar 26, 2015
Merged
ptschip pushed a commit to ptschip/bitcoin that referenced this issue Jun 9, 2016
@gandrewstone
Merge pull request bitcoin#29 from pinheadmz/0.12bu
a4e65a7 
Typo: "1 block has" / "0 blocks have"
destenson pushed a commit to destenson/bitcoin--bitcoin that referenced this issue Jun 26, 2016
@darkcoinproject
Merge pull request bitcoin#29 from mitsukarenai/master
8a4a50c 
Add Debian menu entry + icon
braydonf added a commit to braydonf/bitcoin that referenced this issue Aug 22, 2016
@braydonf
Merge pull request bitcoin#29 from danjurious/logicalts
de6f29e 
logical timestamp indexing of block hashes
@gmaxwell gmaxwell mentioned this issue Mar 15, 2017
Closed
tmagik pushed a commit to tmagik/bitcoin that referenced this issue Jul 1, 2017
@jgarzik
[consensus] Require large block at SegWit+BIP102HeightDelta fork point
b368c9b 
Implements issue bitcoin#29
Supercedes bitcoin#35
@dooglus dooglus mentioned this issue Aug 25, 2017
Closed
maflcko referenced this issue in maflcko/bitcoin-core Sep 29, 2017
Squashed 'src/univalue/' changes from 16a1f7f..fe805ea
619bb05 
fe805ea Declare single-argument (non-converting) constructors "explicit"
8a2d6f1 Merge pull request #41 from jgarzik/get-obj-map
ba341a2 Add getObjMap() helper method.  Also, constify checkObject().
ceb1194 Handle .pushKV() and .checkObject() edge cases.
107db98 Add ::push_back(double) method for feature parity.
d415300 Move one-line implementation of UniValue::read() to header.
52e85b3 Move exception-throwing get_* methods into separate implementation module.
dac5296 README.md: update code quotes
3e31dcf README.md: close code quote
d09b842 Update README.md
f1b86ed Convert README to markdown style.
1dfe464 Import UniValue class unit tests from bitcoin project.
0d3e74d operator[] takes size_t index parameter (versus unsigned int)
640158f Private findKey() method becomes size_t clean, and returns bool on failure.
7099135 Merge pull request #36 from ryanofsky/pr/end-str
a31231b Version 1.0.3
4fd5444 Reject unterminated strings
81eba33 Merge pull request #26 from isle2983/pushBackHelpers
3640541 Merge PR #32 from branch 'nul-not-special' of git://github.com/ryanofsky/univalue into merge
89bb073 Merge pull request #31 from ryanofsky/raw-literals
511008c Merge pull request #30 from ryanofsky/test-driver
77974f3 Merge pull request #34 from paveljanik/20161116_Wshadow_codepoint
a38fcd3 Do not shadow member variable codepoint.
fd32d1a Don't require nul-terminated string inputs
0bb1439 Support parsing raw literals in UniValue
28876d0 Merge pull request #29 from btcdrak/exportspace
839ccd7 Add test driver for JSONTestSuite
26ef3ff Remove trailing whitespace from JSON export
cfa0384 Convenience wrappers for push_back-ing integer types
REVERT: 16a1f7f Merge bitcoin#3: Pull upstream
REVERT: daf1285 Merge pull request #2 from jgarzik/master
REVERT: f32df99 Merge branch '2016_04_unicode' into bitcoin
REVERT: 280b191 Merge remote-tracking branch 'jgarzik/master' into bitcoin
REVERT: 2740c4f Merge branch '2015_11_escape_plan' into bitcoin

git-subtree-dir: src/univalue
git-subtree-split: fe805ea
classesjack pushed a commit to classesjack/bitcoin that referenced this issue Jan 2, 2018
@Earlz
Merge pull request bitcoin#29 from qtumproject/minsk-team/FIX-issue#26
09ca3c4 
Fixed issue#26.
HashUnlimited referenced this issue in chaincoin/chaincoin Mar 12, 2018
Squashed 'src/univalue/' changes from 16a1f7f..fe805ea
b84bc05 
fe805ea Declare single-argument (non-converting) constructors "explicit"
8a2d6f1 Merge pull request #41 from jgarzik/get-obj-map
ba341a2 Add getObjMap() helper method.  Also, constify checkObject().
ceb1194 Handle .pushKV() and .checkObject() edge cases.
107db98 Add ::push_back(double) method for feature parity.
d415300 Move one-line implementation of UniValue::read() to header.
52e85b3 Move exception-throwing get_* methods into separate implementation module.
dac5296 README.md: update code quotes
3e31dcf README.md: close code quote
d09b842 Update README.md
f1b86ed Convert README to markdown style.
1dfe464 Import UniValue class unit tests from bitcoin project.
0d3e74d operator[] takes size_t index parameter (versus unsigned int)
640158f Private findKey() method becomes size_t clean, and returns bool on failure.
7099135 Merge pull request #36 from ryanofsky/pr/end-str
a31231b Version 1.0.3
4fd5444 Reject unterminated strings
81eba33 Merge pull request #26 from isle2983/pushBackHelpers
3640541 Merge PR #32 from branch 'nul-not-special' of git://github.com/ryanofsky/univalue into merge
89bb073 Merge pull request #31 from ryanofsky/raw-literals
511008c Merge pull request #30 from ryanofsky/test-driver
77974f3 Merge pull request #34 from paveljanik/20161116_Wshadow_codepoint
a38fcd3 Do not shadow member variable codepoint.
fd32d1a Don't require nul-terminated string inputs
0bb1439 Support parsing raw literals in UniValue
28876d0 Merge pull request #29 from btcdrak/exportspace
839ccd7 Add test driver for JSONTestSuite
26ef3ff Remove trailing whitespace from JSON export
cfa0384 Convenience wrappers for push_back-ing integer types
REVERT: 16a1f7f Merge #3: Pull upstream
REVERT: daf1285 Merge pull request #2 from jgarzik/master
REVERT: f32df99 Merge branch '2016_04_unicode' into bitcoin
REVERT: 280b191 Merge remote-tracking branch 'jgarzik/master' into bitcoin
REVERT: 2740c4f Merge branch '2015_11_escape_plan' into bitcoin

git-subtree-dir: src/univalue
git-subtree-split: fe805ea

Conflicts:
	Makefile.am
	README.md
	configure.ac
	src/univalue/README
KrzysiekJ pushed a commit to KrzysiekJ/bitcoin that referenced this issue Mar 28, 2018
@janko33bd
Merge pull request bitcoin#29 from tomasoashtonkai/Blackcoin-Lore
6bb3826 
Fix Testnet crash under windows
@davidstoneham davidstoneham mentioned this issue Apr 5, 2018
Open
@kayront kayront mentioned this issue Apr 18, 2019
Closed
@udovdh udovdh mentioned this issue Oct 4, 2019
Closed
velesnetwork referenced this issue in velescore/veles Jan 12, 2020
@velesnetwork
Merge #29: [Qt]: Redesign GUI wallet, add QSS support
ee7d8cb 
- new official black & white Veles GUI theme with bootstrap-like buttons
- replace single-color toolbar icons with full color icons, replaced single color icon set
- redesign splash screen, alternate splash screens for testnet and pre-release builds
- add support for QSS stylesheets
- add dev features of loading external QSS / dumping built-in theme to QSS file
velesnetwork referenced this issue in velescore/veles Jan 12, 2020
@velesnetwork
Merge #31: [0.17] [Qt] Backport #29 [Build] Backport #30
5771683 
Backport from master (pre-0.18):
- Merge #29: [Qt]: Redesign GUI wallet, add QSS support
- Merge #30: [Build]: Add rc number and build to package version
maflcko pushed a commit that referenced this issue May 15, 2021
Merge #21948: test: Fix off-by-one in mockscheduler test RPC
c857148 
fa2e614 test: Fix off-by-one in mockscheduler test RPC (MarcoFalke)

Pull request description:

  Fixes:

  ```
  fuzz: scheduler.cpp:83: void CScheduler::MockForward(std::chrono::seconds): Assertion `delta_seconds.count() > 0 && delta_seconds < std::chrono::hours{1}' failed.
  ==1059066== ERROR: libFuzzer: deadly signal
      #0 0x558f75449c10 in __sanitizer_print_stack_trace (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5fec10)
      #1 0x558f753f32b8 in fuzzer::PrintStackTrace() fuzzer.o
      #2 0x558f753d68d3 in fuzzer::Fuzzer::CrashCallback() fuzzer.o
      #3 0x7f4a3cbbb3bf  (/lib/x86_64-linux-gnu/libpthread.so.0+0x153bf)
      #4 0x7f4a3c7ff18a in raise (/lib/x86_64-linux-gnu/libc.so.6+0x4618a)
      #5 0x7f4a3c7de858 in abort (/lib/x86_64-linux-gnu/libc.so.6+0x25858)
      #6 0x7f4a3c7de728  (/lib/x86_64-linux-gnu/libc.so.6+0x25728)
      #7 0x7f4a3c7eff35 in __assert_fail (/lib/x86_64-linux-gnu/libc.so.6+0x36f35)
      #8 0x558f7588a913 in CScheduler::MockForward(std::chrono::duration<long, std::ratio<1l, 1l> >) scheduler.cpp:83:5
      #9 0x558f75b0e5b1 in mockscheduler()::$_7::operator()(RPCHelpMan const&, JSONRPCRequest const&) const rpc/misc.cpp:435:30
      #10 0x558f75b0e5b1 in std::_Function_handler<UniValue (RPCHelpMan const&, JSONRPCRequest const&), mockscheduler()::$_7>::_M_invoke(std::_Any_data const&, RPCHelpMan const&, JSONRPCRequest const&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:285:9
      #11 0x558f7587a141 in std::function<UniValue (RPCHelpMan const&, JSONRPCRequest const&)>::operator()(RPCHelpMan const&, JSONRPCRequest const&) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      #12 0x558f7587a141 in RPCHelpMan::HandleRequest(JSONRPCRequest const&) const rpc/util.cpp:565:26
      #13 0x558f756c0086 in CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::'lambda'(JSONRPCRequest const&, UniValue&, bool)::operator()(JSONRPCRequest const&, UniValue&, bool) const ./rpc/server.h:110:91
      #14 0x558f756c0086 in std::_Function_handler<bool (JSONRPCRequest const&, UniValue&, bool), CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::'lambda'(JSONRPCRequest const&, UniValue&, bool)>::_M_invoke(std::_Any_data const&, JSONRPCRequest const&, UniValue&, bool&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:285:9
      #15 0x558f756b8592 in std::function<bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      #16 0x558f756b8592 in ExecuteCommand(CRPCCommand const&, JSONRPCRequest const&, UniValue&, bool) rpc/server.cpp:480:20
      #17 0x558f756b8592 in ExecuteCommands(std::vector<CRPCCommand const*, std::allocator<CRPCCommand const*> > const&, JSONRPCRequest const&, UniValue&) rpc/server.cpp:444:13
      #18 0x558f756b8017 in CRPCTable::execute(JSONRPCRequest const&) const rpc/server.cpp:464:13
      #19 0x558f7552457a in (anonymous namespace)::RPCFuzzTestingSetup::CallRPC(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) test/fuzz/rpc.cpp:50:25
      #20 0x558f7552457a in rpc_fuzz_target(Span<unsigned char const>) test/fuzz/rpc.cpp:354:28
      #21 0x558f7544cf0f in std::_Function_handler<void (Span<unsigned char const>), void (*)(Span<unsigned char const>)>::_M_invoke(std::_Any_data const&, Span<unsigned char const>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:300:2
      #22 0x558f75c05197 in std::function<void (Span<unsigned char const>)>::operator()(Span<unsigned char const>) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
      #23 0x558f75c05197 in LLVMFuzzerTestOneInput test/fuzz/fuzz.cpp:74:5
      #24 0x558f753d8073 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) fuzzer.o
      #25 0x558f753c1f72 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) fuzzer.o
      #26 0x558f753c7d6a in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) fuzzer.o
      #27 0x558f753f3a92 in main (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x5a8a92)
      #28 0x7f4a3c7e00b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
      #29 0x558f7539cc9d in _start (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x551c9d)

ACKs for top commit:
  practicalswift:
    cr ACK fa2e614

Tree-SHA512: cfa120265261f0ad019b46c426b915c1c007806b37aecb27016ce780a0ddea5e6fc9b09065fd40684b11183dcd3bf543558d7a655e604695021653540266baf7
hebasto added a commit that referenced this issue Jun 12, 2021
@hebasto
Merge bitcoin-core/gui#333: refactor: Signal-slot connections cleanup
6f3fbc0 
f507681 qt: Connect WalletView signal to BitcoinGUI slot directly (Hennadii Stepanov)
bd50ff9 qt: Drop redundant OverviewPage::handleOutOfSyncWarningClicks slot (Hennadii Stepanov)
793f195 qt: Drop redundant WalletView::requestedSyncWarningInfo slot (Hennadii Stepanov)

Pull request description:

  This PR:
  - removes slots whose only job is to emit a signal, since we can use the signal as a slot
  - connects the`WalletView::outOfSyncWarningClicked` signal to the `BitcoinGUI::showModalOverlay` slot directly, and removes intermediate `WalletFrame` slot and signal
  - split from #29

  This PR does not change behavior.

ACKs for top commit:
  Talkless:
    tACK f507681, tested on Debian Sid with Qt 5.15.2, no any behavioral changes noticed.
  promag:
    Code review ACK f507681.

Tree-SHA512: cd636a7e61881b2cbee84d5425d2107a8e39683b8eb32d79dc9ea942db55d5c1979be2f70da1660eaee5de622d10ed5a92f11fc2351de21b84324b10b23d0c96
hebasto added a commit that referenced this issue Aug 5, 2021
@hebasto
Merge bitcoin-core/gui#393: Fix regression in "Encrypt Wallet" menu item
e9472e6 
d54d949 qt: Fix regression in "Encrypt Wallet" menu item (Hennadii Stepanov)

Pull request description:

  Fix #392.

  Adding a new item to the `m_wallet_selector` must follow the establishment of a connection between the `WalletView::encryptionStatusChanged` signal and the `BitcoinGUI::updateWalletStatus` slot.

  This was a regression introduced in 20e2e24 (#29).

  ---

  An _encrypted_ wallet being auto-loaded at the GUI startup:
  - on master (eaf09bd)

  ![Screenshot from 2021-08-03 22-38-49](https://user-images.githubusercontent.com/32963518/128075837-cdbb2047-5327-43ea-b2d5-2dcdef67cdc0.png)

  - with this PR

  ![Screenshot from 2021-08-03 22-34-58](https://user-images.githubusercontent.com/32963518/128075572-cb727652-ad44-4b85-bf64-edcd19f9dea1.png)

ACKs for top commit:
  achow101:
    ACK d54d949
  jarolrod:
    ACK d54d949

Tree-SHA512: 669615ec8e1517c2f4cdf59bd11a7c85be793ba0dda112361cf95e6c2f0636215fed331d26a86dc9b779a49defae1b248232f98dab449584376c111c288e87bb
rajarshimaitra pushed a commit to rajarshimaitra/bitcoin that referenced this issue Aug 5, 2021
@practicalswift @renepickhardt
travis: Add automatic spell checking of new pull requests using codes…
d8a8343 
…pell (bitcoin#29)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
promag pushed a commit to promag/bitcoin that referenced this issue Sep 28, 2021
@hebasto
Merge bitcoin-core/gui-qml#30: build: Fix qt build for riscv64
92b8249 
3a0f948 build, qt: Apply workaround for Qt build system bug for riscv64 (Hennadii Stepanov)
f17a32a build, qt: Add RISC-V detection (Hennadii Stepanov)

Pull request description:

  Fixes bitcoin#29.

  #### Guix build:
  ```
  $ env HOSTS='riscv64-linux-gnu' ./contrib/guix/guix-build
  $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
  9399101a4268eb78b4c13d0895964862211d87e9a12bd154c11ea4ca257f02d6  guix-build-3a0f948c0bc9/output/dist-archive/bitcoin-3a0f948c0bc9.tar.gz
  c4c57780ee1d99721dc370c35cc68dfccdd5455a29c0c526a1171f3b8dfa4dc8  guix-build-3a0f948c0bc9/output/riscv64-linux-gnu/SHA256SUMS.part
  4840f8a57c43e3956073681aeb3779f326fa89102a643c5bf5acd26790107284  guix-build-3a0f948c0bc9/output/riscv64-linux-gnu/bitcoin-3a0f948c0bc9-riscv64-linux-gnu-debug.tar.gz
  95910c5070e14532c2b96a10662c1ae77c45199649234248ee71017e15cc7a71  guix-build-3a0f948c0bc9/output/riscv64-linux-gnu/bitcoin-3a0f948c0bc9-riscv64-linux-gnu.tar.gz
  ```

ACKs for top commit:
  jarolrod:
    ACK 3a0f948

Tree-SHA512: c1f941f8530f5cc5ae88e9fa38c91107f9d7f67f77d5e8aa99990b2a056bf1e7a63c39ffe12569a1d202d660ea1a41f4dac053f383f3d50d2441fca0e59f8e43
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gavinandresen @tcatm