Bugfix: make CCoinsViewMemPool support pruned entries in underlying cache #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good: I found this problem whilst extending the pull tester with getutxo tests, and this fixes the bug for me. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4575_ad08d0b95bd8e35b74f5f36cfa3c48ae9583b28c/ for binaries and test log. |
|
Untested ACK |
laanwj
added a commit
that referenced
this pull request
Jul 24, 2014
ad08d0b Bugfix: make CCoinsViewMemPool support pruned entries in underlying cache (Pieter Wuille)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #4505 it can happen that pcoinsTip contains pruned but existing CCoins entries, representing deleted/reorged transactions.
CCoinsViewMemPool::GetCoins does not deal correctly with this, as it first checks for an entry in the underlying cache (which can be pruned) and then for one in the mempool. Swap these, as the mempool is guaranteed never to conflict with the underlying cache, and the mempool cannot contain pruned transactions.
Thanks to @mikehearn for reporting.