Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Display addresses" checkbox #4580

Closed
kazcw opened this issue Jul 24, 2014 · 2 comments · Fixed by #4610
Closed

"Display addresses" checkbox #4580

kazcw opened this issue Jul 24, 2014 · 2 comments · Fixed by #4610
Labels
GUI Wallet

Comments

@kazcw
Copy link
Contributor

kazcw commented Jul 24, 2014

In the QT gui, in the Display tab of the options, the "Display addresses in transaction list" checkbox doesn't seem to affect the Transactions pane of the main window -- addresses are always displayed.

I don't know why it'd be useful to turn off addresses in the Transactions pane. Should we just remove the checkbox?
@laanwj
Copy link
Member

laanwj commented Jul 24, 2014

ACK on removing it.

It does affect some things (try enabling it, you'll see LOTS more addresses in addition to the labels). This was something introduced in a bikeshedding discussion a long time ago, so eventually it was decided to make it an option to be able to make progress at all.

But I doubt anyone is actually using/testing it so it's better to remove it.

@kazcw kazcw changed the title broken checkbox in options? "Display addresses" checkbox Jul 24, 2014
laanwj added a commit that referenced this issue Jul 31, 2014
@laanwj
qt: Remove an obscure option no-one cares about
bdba2dd 
Remove the "Display addresses" setting checkbox. It doesn't do what
the tooltip says, and seems kind of pointless in any case.

Fixes #4580.
@laanwj laanwj mentioned this issue Jul 31, 2014
Merged
wtogami pushed a commit to wtogami/bitcoin that referenced this issue Sep 10, 2014
@laanwj @wtogami
qt: Remove an obscure option no-one cares about
fffb0e9 
Remove the "Display addresses" setting checkbox. It doesn't do what
the tooltip says, and seems kind of pointless in any case.

Fixes bitcoin#4580.

Rebased-from: bdba2dd
wtogami pushed a commit to litecoin-project/litecoin that referenced this issue Sep 19, 2014
@laanwj @wtogami
qt: Remove an obscure option no-one cares about
ebf96cc 
Remove the "Display addresses" setting checkbox. It doesn't do what
the tooltip says, and seems kind of pointless in any case.

Fixes bitcoin#4580.

Rebased-from: bdba2dd
wtogami pushed a commit to litecoin-project/litecoin that referenced this issue Oct 2, 2014
@laanwj @wtogami
qt: Remove an obscure option no-one cares about
675e242 
Remove the "Display addresses" setting checkbox. It doesn't do what
the tooltip says, and seems kind of pointless in any case.

Fixes bitcoin#4580.

Rebased-from: bdba2dd
wtogami pushed a commit to litecoin-project/litecoin that referenced this issue Nov 14, 2014
@laanwj @wtogami
qt: Remove an obscure option no-one cares about
220a425 
Remove the "Display addresses" setting checkbox. It doesn't do what
the tooltip says, and seems kind of pointless in any case.

Fixes bitcoin#4580.

Rebased-from: bdba2dd
MathyV pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this issue Nov 24, 2014
@laanwj @MathyV
qt: Remove an obscure option no-one cares about
b1f3979 
Remove the "Display addresses" setting checkbox. It doesn't do what
the tooltip says, and seems kind of pointless in any case.

Fixes bitcoin#4580.

Conflicts:
	src/qt/forms/optionsdialog.ui
wtogami pushed a commit to litecoin-project/litecoin that referenced this issue Dec 23, 2014
@laanwj @wtogami
qt: Remove an obscure option no-one cares about
d294181 
Remove the "Display addresses" setting checkbox. It doesn't do what
the tooltip says, and seems kind of pointless in any case.

Fixes bitcoin#4580.

Rebased-from: bdba2dd
@luke-jr
Copy link
Member

luke-jr commented Feb 26, 2015

Since this, it is impossible to see addresses in the Transactions pane. Can we add it back? Maybe with a better description if the old one was confusing... (although it makes sense to me)

@laanwj laanwj mentioned this issue Mar 6, 2015
Closed
reddink pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this issue May 27, 2020
@laanwj @reddink
qt: Remove an obscure option no-one cares about
d874286 
Remove the "Display addresses" setting checkbox. It doesn't do what
the tooltip says, and seems kind of pointless in any case.

Fixes bitcoin#4580.

(cherry picked from commit bdba2dd)

# Conflicts:
#	src/qt/forms/optionsdialog.ui
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
GUI Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

qt: Remove an obscure option no-one cares about laanwj/bitcoin
3 participants
@laanwj @kazcw @luke-jr