Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] Payment request via Tor and BitPay - a NO go #5204

Closed
Diapolo opened this issue Nov 4, 2014 · 14 comments
Closed

[Qt] Payment request via Tor and BitPay - a NO go #5204

Diapolo opened this issue Nov 4, 2014 · 14 comments

Comments

@Diapolo
Copy link

Diapolo commented Nov 4, 2014

Most likely this is a no-issue for us, because we can't solve it, but perhaps we can brainstorm some ideas if we can extend error messages or reporting stuff to users.

This is what happened, I tried to pay via BitPay using my Bitcoin Core wallet while connected to the network via Tor. After clicking the payment button on the BitPay site I got this warning displayed to me (this is from my debug.log):
GUI: PaymentServer::netRequestFinished : "Kommunikationsfehler mit https://bitpay.com/i/XYZ: Error downloading https://bitpay.com/i/XYZ - server replied: Forbidden"

I know that BitPay is using Cloudflare as hoster or technical base and that Cloudflare is blocking Tor exit nodes! This is "only" annoying if visiting their site via browser, as they offer a (stupid) captcha. But it get's totally stupid if using payment requests on their site, because of not being able to proceed.

I had to reconnect with Tor disabled to do my payment, which sucked! Any ideas, for how we could handle such a case or error situation from a UX view?

@laanwj
Copy link
Member

laanwj commented Nov 5, 2014

Even with Bitpay you can get the address/amount and pay manually. But it's kind of stupid that you can't get the payment request through tor. You should file an issue with them.

@Diapolo
Copy link
Author

Diapolo commented Nov 5, 2014

Done...

@Diapolo
Copy link
Author

Diapolo commented Nov 6, 2014

It's the cause of CloudFlare IP-based reputation system, which blocks Tor because "plenty of spam and malware uses Tor", so "few bad actors on Tor have made using Tor difficult for legitimate users". IMHO their system is fucked when using Tor and I told em exactly that. It seems they want to improve things, dunno how and when.

@laanwj Anything for us that could be done for the users from us!?

@theuni
Copy link
Member

theuni commented Nov 6, 2014

@Diapolo From a quick test, cloudflare returns a 403 in this case. I'm not sure how common it is that we would see that. Maybe it's worth adding a msgbox with a hint that this may be the cause for the "tor + 403" case?

@Diapolo
Copy link
Author

Diapolo commented Nov 7, 2014

@theuni Right, I had the same idea, but I'm unsure how to quickly tell that the set proxy is indeed a Tor proxy (and we not only set derived it from -proxy, which doesn't need to be a Tor one)...

@laanwj
Copy link
Member

laanwj commented Nov 7, 2014

@Diapolo No need to be sure of that. You could add the hint either case, the user will know if he's using Tor or not so whether to regard it or not.

@laanwj
Copy link
Member

laanwj commented Oct 31, 2015

I think this is still an issue?

@laanwj laanwj reopened this Dec 31, 2017
@laanwj
Copy link
Member

laanwj commented Dec 31, 2017

I've heard reports that this is still an issue, and it became more serious now that bitpay has no way to manually specify address/amount anymore. Even when not using tor, the cloudflare protection might trigger.

@TheBlueMatt
Copy link
Contributor

I think the appropriate fix is to encourage more wallets to use tor to send payment requests and default to using tor if there is a tor proxy configured ourselves. Not being able to send a payment request over Tor is an issue the provider needs to fix, not us.

@iamvinny
Copy link

iamvinny commented Jan 4, 2018

They have started using "Payment Protocol" (BIP 70) recently, it's hurting my business, because my customers can't pay without a specific wallet, I'll be switching to another payment processor. BitPay is only getting worse and worse...

@iamvinny
Copy link

iamvinny commented Jan 4, 2018

They have published an article today, explaining why this issue happens for TOR users, and a possible workaround, worth reading.

https://support.bitpay.com/hc/en-us/articles/115003014566-Why-can-t-I-pay-a-BitPay-invoice-in-my-Tor-browser-

@Stefanie80
Copy link

New problem: even payments using a supported wallet do not work anymore. Obviously has something to do with the cloudflare DDoS protection, wich prevents wallets from getting the payment details. R.I.P BitPay.
I have now installed the wallet from bitpay itself, going to test if that works. And will also reccomend to the merchant to switch to another payment processor. This is a major setback to bitcoin as a whole, because many merchants used BitPay.

@Sjors
Copy link
Member

Sjors commented Jul 31, 2018

This is still an issue as of a few days ago. As pointed out above made worse by BitPay's BIP-70 enforcement.

One solution could be to - if a request fails - offer the user to redo the request without Tor (default "No"). That's arguably better than telling users to turn Tor off. Perhaps the message could clarify that if they alrady use a non-Tor browser to place the order, there's probably not much downside, while at the same time reminding them that combining Tor with non-Tor is problematic in general.

@laanwj
Copy link
Member

laanwj commented Aug 6, 2019

Closing payment protocol specific issues; as that functionality is going to be deprecated in the near future it's not worth working on.

@laanwj laanwj closed this as completed Aug 6, 2019
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants