listunspent's new include_unsafe parameter doesn't work

[dooglus]

$ ./bitcoin-cli listunspent 0 9999999 '[]' true
error code: -3
error message:
Expected type bool, got string

rpc/client.cpp probably needs to list the parameter along with the other 3:

    { "listunspent", 0, "minconf" },
    { "listunspent", 1, "maxconf" },
    { "listunspent", 2, "addresses" },

Add this?

    { "listunspent", 3, "include_unsafe" },

[NicolasDorier]

I confirm. This is strange I would have swear I already used it successfully.
I do not see what is wrong with the code either...

[dooglus]

rpc/client.cpp needs to list the parameter as needing interpretation for any non-string parameter.

Can confirm that this change fixes the problem:

diff --git a/src/rpc/client.cpp b/src/rpc/client.cpp
index 5bdd84e..16eb723 100644
--- a/src/rpc/client.cpp
+++ b/src/rpc/client.cpp
@@ -79,6 +79,7 @@ static const CRPCConvertParam vRPCConvertParams[] =
     { "listunspent", 0, "minconf" },
     { "listunspent", 1, "maxconf" },
     { "listunspent", 2, "addresses" },
+    { "listunspent", 3, "include_unsafe" },
     { "getblock", 1, "verbose" },
     { "getblockheader", 1, "verbose" },
     { "gettransaction", 1, "include_watchonly" },

[jonasschnelli]

Good catch. Thanks @dooglus

[dooglus]

Do I need to make a pull request for this? It seems to have been missed in 0.14.1 rc1.