Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add P2P, Network, and Qt categories to the desktop icon #12854

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Add P2P, Network, and Qt categories to the desktop icon #12854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contrib/debian/bitcoin-qt.desktop
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ Terminal=false
Type=Application
Icon=bitcoin128
MimeType=x-scheme-handler/bitcoin;
Categories=Office;Finance;
Categories=Office;Finance;P2P;Network;Qt;
Copy link
Member

@laanwj laanwj Apr 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don 't think Qt is a useful category. It's like adding C++. Not relevant to classifying the application.
Agree with adding P2P or Network though I'd say one of them is enough (but adding both is fine with me...).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Qt category is defined as "Application based on Qt libraries", which certainly applies to bitcoin-qt.

https://specifications.freedesktop.org/menu-spec/latest/apas02.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, okay.
Well if it's part of the standard then ok...

StartupWMClass=Bitcoin-qt