Remove mapRequest tracking that just effects Qt display. #13622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought we had removed this a long time ago, TBH, its really confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far.
TheBlueMatt
changed the title
|
ACK. I also thought so too. LGTM. |
|
utACK beef7ec |
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
@laanwj Heh, I don't even remember anymore. Concept ACK, the current approach isn't a good way to measure network propagation anyway. |
|
We'd want to do something different (which would also be much more effective and less confusing) after dandelion and/mempool sync is implemented, anyways. |
|
utACK beef7ec |
Right, in one direction it is: if a transaction has not been requested by any other node, you can be sure it hasn't propagated. But not the other way around. |
|
utACK beef7ec |
laanwj
added a commit
that referenced
this pull request
Jul 11, 2018
beef7ec Remove useless mapRequest tracking that just effects Qt display. (Matt Corallo) Pull request description: I thought we had removed this a long time ago, TBH, its really confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far. Tree-SHA512: c9d0808fb60146919bb78d0860ec2193601966c944887eaae7837408422f7e85dfdb306407a613200cdd4726aec66da18df618ebc6a8cfe8650bf08d4a8dc155
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jul 12, 2018
I thought we had removed this a long time ago, TBH, its really confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far. Github-Pull: bitcoin#13622 Rebased-From: beef7ec
|
utACK beef7ec |
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Oct 28, 2018
qt: After merging bitcoin#13622 the `adjustedTime` is not used any more in wallet related functions.
laanwj
added a commit
that referenced
this pull request
Nov 5, 2018
04972fe Remove unused `adjustedTime` parameter (Hennadii Stepanov) Pull request description: After merging #13622 the `adjustedTime` parameter in the `updateStatus` function is unused. Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626
HashUnlimited
pushed a commit
to chainworksindustries/ozc-0.17.99.0-hu
that referenced
this pull request
Nov 5, 2018
qt: After merging bitcoin#13622 the `adjustedTime` is not used any more in wallet related functions.
jfhk
pushed a commit
to jfhk/bitcoin
that referenced
this pull request
Nov 14, 2018
qt: After merging bitcoin#13622 the `adjustedTime` is not used any more in wallet related functions.
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Nov 26, 2018
qt: After merging bitcoin#13622 the `adjustedTime` is not used any more in wallet related functions.
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Jan 11, 2019
I thought we had removed this a long time ago, TBH, its really confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far. Github-Pull: bitcoin#13622 Rebased-From: beef7ec
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 9, 2020
…display. beef7ec Remove useless mapRequest tracking that just effects Qt display. (Matt Corallo) Pull request description: I thought we had removed this a long time ago, TBH, its really confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far. Tree-SHA512: c9d0808fb60146919bb78d0860ec2193601966c944887eaae7837408422f7e85dfdb306407a613200cdd4726aec66da18df618ebc6a8cfe8650bf08d4a8dc155 Signed-off-by: pasta <pasta@dashboost.org> # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/net_processing.cpp # src/qt/guiconstants.h # src/qt/transactiondesc.cpp # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp # src/validationinterface.cpp # src/validationinterface.h # src/wallet/wallet.cpp
UdjinM6
pushed a commit
to dashpay/dash
that referenced
this pull request
Sep 12, 2020
…display. (#3694) * Merge bitcoin#13622: Remove mapRequest tracking that just effects Qt display. beef7ec Remove useless mapRequest tracking that just effects Qt display. (Matt Corallo) Pull request description: I thought we had removed this a long time ago, TBH, its really confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far. Tree-SHA512: c9d0808fb60146919bb78d0860ec2193601966c944887eaae7837408422f7e85dfdb306407a613200cdd4726aec66da18df618ebc6a8cfe8650bf08d4a8dc155 Signed-off-by: pasta <pasta@dashboost.org> # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/net_processing.cpp # src/qt/guiconstants.h # src/qt/transactiondesc.cpp # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp # src/validationinterface.cpp # src/validationinterface.h # src/wallet/wallet.cpp * drop TX_STATUS_OFFLINE Signed-off-by: pasta <pasta@dashboost.org> Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com>
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 12, 2020
…display. (dashpay#3694) * Merge bitcoin#13622: Remove mapRequest tracking that just effects Qt display. beef7ec Remove useless mapRequest tracking that just effects Qt display. (Matt Corallo) Pull request description: I thought we had removed this a long time ago, TBH, its really confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far. Tree-SHA512: c9d0808fb60146919bb78d0860ec2193601966c944887eaae7837408422f7e85dfdb306407a613200cdd4726aec66da18df618ebc6a8cfe8650bf08d4a8dc155 Signed-off-by: pasta <pasta@dashboost.org> * drop TX_STATUS_OFFLINE Signed-off-by: pasta <pasta@dashboost.org> Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com>
4 tasks
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 29, 2021
…cts Qt display.
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jun 29, 2021
…cts Qt display.
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jul 1, 2021
…cts Qt display.
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jul 2, 2021
…cts Qt display.
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Jul 2, 2021
…cts Qt display.
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 22, 2021
04972fe Remove unused `adjustedTime` parameter (Hennadii Stepanov) Pull request description: After merging bitcoin#13622 the `adjustedTime` parameter in the `updateStatus` function is unused. Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626 # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 22, 2021
04972fe Remove unused `adjustedTime` parameter (Hennadii Stepanov) Pull request description: After merging bitcoin#13622 the `adjustedTime` parameter in the `updateStatus` function is unused. Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626 # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 22, 2021
04972fe Remove unused `adjustedTime` parameter (Hennadii Stepanov) Pull request description: After merging bitcoin#13622 the `adjustedTime` parameter in the `updateStatus` function is unused. Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626 # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 22, 2021
04972fe Remove unused `adjustedTime` parameter (Hennadii Stepanov) Pull request description: After merging bitcoin#13622 the `adjustedTime` parameter in the `updateStatus` function is unused. Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626 # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 23, 2021
04972fe Remove unused `adjustedTime` parameter (Hennadii Stepanov) Pull request description: After merging bitcoin#13622 the `adjustedTime` parameter in the `updateStatus` function is unused. Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626 # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 23, 2021
04972fe Remove unused `adjustedTime` parameter (Hennadii Stepanov) Pull request description: After merging bitcoin#13622 the `adjustedTime` parameter in the `updateStatus` function is unused. Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626 # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 23, 2021
04972fe Remove unused `adjustedTime` parameter (Hennadii Stepanov) Pull request description: After merging bitcoin#13622 the `adjustedTime` parameter in the `updateStatus` function is unused. Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626 # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 23, 2021
04972fe Remove unused `adjustedTime` parameter (Hennadii Stepanov) Pull request description: After merging bitcoin#13622 the `adjustedTime` parameter in the `updateStatus` function is unused. Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626 # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 26, 2021
04972fe Remove unused `adjustedTime` parameter (Hennadii Stepanov) Pull request description: After merging bitcoin#13622 the `adjustedTime` parameter in the `updateStatus` function is unused. Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626 # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 27, 2021
04972fe Remove unused `adjustedTime` parameter (Hennadii Stepanov) Pull request description: After merging bitcoin#13622 the `adjustedTime` parameter in the `updateStatus` function is unused. Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626 # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 28, 2021
04972fe Remove unused `adjustedTime` parameter (Hennadii Stepanov) Pull request description: After merging bitcoin#13622 the `adjustedTime` parameter in the `updateStatus` function is unused. Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626 # Conflicts: # src/interfaces/wallet.cpp # src/interfaces/wallet.h # src/qt/transactionrecord.cpp # src/qt/transactionrecord.h # src/qt/transactiontablemodel.cpp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought we had removed this a long time ago, TBH, its really
confusing feedback to users that we display whether a tx was
broadcast to immediate neighbor nodes, given that has little
indication of whether the tx propagated very far.