remove dead "using namespace boost::asio;" from rpcdump.cpp #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgarzik
pushed a commit
that referenced
this pull request
May 24, 2012
remove dead "using namespace boost::asio;" from rpcdump.cpp
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
remove dead "using namespace boost::asio;" from rpcdump.cpp
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
* Forward potential double spends as quickly as possible. When we have a conflict, which could be a double spend, we need to notify the commitQ thread to run immediately which also processes the deferred queue. In this way a double spend will get processed and forwarded as quick as possible, whearas, if we don't do this it could be up to 2 seconds before the double spend is processed and forwarded. And then on the next peer it could be another 2 seconds and so forth, causing double spends to trickle slowly through the network.
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
aa7ff86 [GUI][Wallet] Use unlock context for HD upgrade (random-zebra) 060790f [Doc] Add Context Lock/Unlock to release notes (random-zebra) dee68e3 [Refactor] Use isWalletUnlocked() to check valid in requestUnlock() (random-zebra) 556a176 [GUI][Model] Remove verifyWalletUnlocked and connect everything (random-zebra) 1c803f0 [UI][Model] Connect WalletModel::requireUnlock (random-zebra) 31cbef7 [Refactor] Rename ...AnonymizationOnly --> ...StakingOnly (random-zebra) 1a7aa56 [Cleanup] Remove un-used walletpassworddialog (random-zebra) a85deb7 [Wallet][Model] Fix and refactor UnlockContext (random-zebra) 05b1360 [Trivial] Styling: spaces and brackets (random-zebra) Pull request description: Fix `UnlockContext` class and connect it where needed. Now, once an action requires the wallet to be fully unlocked, the askpassphrase dialog is presented to the user (if the status is "Locked" or "UnlockedForStaking"). This way, the password can be entered directly, and the operation can resume without needing additional clicks by the user. The previous locking status is restored when the action completes. Interested flows: - Send transaction (closes bitcoin#1365) - Create New Receive Address - Create New Payment Request - Create Masternode Controller - Create Cold Staking Address (closes bitcoin#1171) - Send Cold Stake Delegation - Wallet Data: Add multisend recipient - Tools: Sign Message - Tools: BIP38 tool - Upgrade wallet to HD Also Closes bitcoin#553 Closes bitcoin#1035 And maybe bitcoin#1152 becomes not needed now. ACKs for top commit: Fuzzbawls: ACK aa7ff86 Tree-SHA512: 21590ca025b8c3a26824fea9c1107b68e0508cc080acbf0e1bf5b1c86da15f5f6696ea680c57989cc0cb8b5f54d328f32a60d24dc3c5ca8526179ef1750b3482
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
53cfbee [GUI] Automatic wallet backup after upgrade to HD (random-zebra) Pull request description: Based on - [x] bitcoin#1387 Offer the option to directly backup the wallet after upgrade-to-HD (and successive re-lock) is completed. The message on the initial dialog is changed (from "Note that you will need to MAKE A NEW BACKUP.."):  If the user clicks "OK", and the wallet is locked, the unlock dialog is directly shown (as per bitcoin#1387)  After the upgrade, the client directly presents this dialog:  If the user clicks "OK", then the open-file dialog is presented, so the user can select the filename for the backup file and click "Save" completing the flow. If the user clicks "CANCEL" (or dismisses the open-file dialog later), a snackbar popup warns the user, telling to remember to backup asap. ACKs for top commit: furszy: Tested ACK 53cfbee. Fuzzbawls: ACK 53cfbee Tree-SHA512: 80fbcdb4d9805d75db98a0f394840f734314e6d249539997f1948cd7775ac2a81239b762386b7770c6ca4b8a2c38acdf1d5ae7ee7f07591bfdfc7dd4ee39cfc2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.