rpc: remove duplicate solvable field from getaddressinfo #15186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK, nice catch. |
fanquake
force-pushed
the
duplicate-solvable-fields
branch
from
99a1b7b
to
a5db68c
Compare
|
Travis failure seems unrelated. Force pushed, added |
|
Huh, how did we have it end up like this, a silent merge conflict? (utACK, good catch) |
|
utACK a5db68c |
|
utACK a5db68c22ba03e661d20b1855e6a443019080690 |
|
Should backport? |
|
@promag bitcoin/src/wallet/rpcwallet.cpp Line 4149 in 0a0b2ea |
maflcko
reviewed
Jan 17, 2019
|
ACK |
|
utACK a5db68c22ba03e661d20b1855e6a443019080690 |
fanquake
force-pushed
the
duplicate-solvable-fields
branch
from
a5db68c
to
a2a6c8f
Compare
|
utAck |
laanwj
added a commit
that referenced
this pull request
Jan 19, 2019
a2a6c8f rpc: remove duplicate solvable field from getaddressinfo (fanquake) Pull request description: Also added optional to `iscompressed`. Tree-SHA512: 28442a9dbfb2a9992b9b57142fa13d374d39444f04ae63460cb6330d896160cfd4b9651a3e231893eac3142ce55eff597a54cbafd3b57ffa46d3711c64044acb
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Nov 24, 2021
…ressinfo a2a6c8f rpc: remove duplicate solvable field from getaddressinfo (fanquake) Pull request description: Also added optional to `iscompressed`. Tree-SHA512: 28442a9dbfb2a9992b9b57142fa13d374d39444f04ae63460cb6330d896160cfd4b9651a3e231893eac3142ce55eff597a54cbafd3b57ffa46d3711c64044acb
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Nov 29, 2021
…ressinfo (#4584) a2a6c8f rpc: remove duplicate solvable field from getaddressinfo (fanquake) Pull request description: Also added optional to `iscompressed`. Tree-SHA512: 28442a9dbfb2a9992b9b57142fa13d374d39444f04ae63460cb6330d896160cfd4b9651a3e231893eac3142ce55eff597a54cbafd3b57ffa46d3711c64044acb Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added optional to
iscompressed.