build: remove deprecated key from macOS Info.plist #17660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. |
|
Concept ACK. I'm not entirely sure the fourth version number should be shown when it is 0. I don't think we historically do this in the application itself? Versions like A.B.C are enough in most cases and look less complex to users. |
|
@laanwj that would require a new var like PR title could be something like "build: Refresh macos Info.plist", I mean it's changing other keys. |
yes… |
|
Concept ACK but agree with @laawnj about the forth version part (should only be shown if != 0). |
|
Technically "Developers" should be capitalized. "The Bitcoin Core Developers" is the entity that holds the copyright. |
|
there is no 'entity that holds the copyright', the project has no CLA |
|
Maybe something other than a copyright notice should be displayed then. https://www.copyright.gov/comp3/chap2200/ch2200-notice.pdf 2204.1 Notice for Works Fixed in Copies Either way. This should be checked as well - it was mentioned on a previous PR. |
|
You'd have to consider copyright internationally, not just for the US. In the context of FOSS. We're ok with mimicing other projects here, as this is very much out of scope of the project, there's not really anything to be gained by going down that rabbit hole. |
|
Thanks for the clarity. |
Note that the current release binaries don't show incorrect version numbers anywhere in the GUI, and we haven't reintroduced the issue that bitcoin#14701 fixed. This is just swapping a deprecated field for a newer one and removing the additional version number.
fanquake
force-pushed
the
remove_deprecated_cfbundle_usage
branch
from
86fd77f
to
c0bc453
Compare
|
I've reduced this to a smaller change, which is just replacing the deprecated key for the newer one. |
|
Would be nice to get a travis build once #17848 is fixed |
Gitian builds
|
|
ACK c0bc453 |
laanwj
added a commit
that referenced
this pull request
Feb 5, 2020
c0bc453 build: remove deprecated key from macOS Info.plist (fanquake) Pull request description: Note that the current release binaries show correct version numbers everywhere in the GUI and macOS info dialogs (except for when you "space" click the app, shown in screenshots), and we haven't reintroduced the issue that #14701 fixed. This is just swapping a deprecated field for a newer one, as well as using the entire version string in two fields that we hadn't been previously. Follows up discussion in #14701. 0.19.0.1  This PR.  ACKs for top commit: laanwj: ACK c0bc453 Tree-SHA512: 6191056d0cb6072b8a2170c8441ebfe500cf00cd41014bf5ee68fbf60b5bb5642e2fad9541f1c5abfaafdae6db3102c3add6169cefce3fc4a63d8b913ea35865
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 9, 2020
c0bc453 build: remove deprecated key from macOS Info.plist (fanquake) Pull request description: Note that the current release binaries show correct version numbers everywhere in the GUI and macOS info dialogs (except for when you "space" click the app, shown in screenshots), and we haven't reintroduced the issue that bitcoin#14701 fixed. This is just swapping a deprecated field for a newer one, as well as using the entire version string in two fields that we hadn't been previously. Follows up discussion in bitcoin#14701. 0.19.0.1  This PR.  ACKs for top commit: laanwj: ACK c0bc453 Tree-SHA512: 6191056d0cb6072b8a2170c8441ebfe500cf00cd41014bf5ee68fbf60b5bb5642e2fad9541f1c5abfaafdae6db3102c3add6169cefce3fc4a63d8b913ea35865
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 19, 2020
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
c0bc453 build: remove deprecated key from macOS Info.plist (fanquake) Pull request description: Note that the current release binaries show correct version numbers everywhere in the GUI and macOS info dialogs (except for when you "space" click the app, shown in screenshots), and we haven't reintroduced the issue that bitcoin#14701 fixed. This is just swapping a deprecated field for a newer one, as well as using the entire version string in two fields that we hadn't been previously. Follows up discussion in bitcoin#14701. 0.19.0.1  This PR.  ACKs for top commit: laanwj: ACK c0bc453 Tree-SHA512: 6191056d0cb6072b8a2170c8441ebfe500cf00cd41014bf5ee68fbf60b5bb5642e2fad9541f1c5abfaafdae6db3102c3add6169cefce3fc4a63d8b913ea35865
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the current release binaries show correct version numbers everywhere in the GUI and macOS info dialogs (except for when you "space" click the app, shown in screenshots), and we haven't reintroduced the issue that #14701 fixed. This is just swapping a deprecated field for a newer one, as well as using the entire version string in two fields that we hadn't been previously.
Follows up discussion in #14701.
0.19.0.1
This PR.
