test: add coverage for purpose arg in listlabels

[brunoerg]

This PR adds test coverage for listlabels command when specifying the purpose (send and receive).

bitcoin/src/wallet/rpc/addresses.cpp

Lines 698 to 704 in dcdfd72

	RPCHelpMan listlabels()
	{
	return RPCHelpMan{"listlabels",
	"\nReturns the list of all labels, or labels that are assigned to addresses with a specific purpose.\n",
	{
	{"purpose", RPCArg::Type::STR, RPCArg::Optional::OMITTED_NAMED_ARG, "Address purpose to list labels for ('send','receive'). An empty string is the same as not providing this argument."},
	},

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	kristapsk
Concept ACK	yusufsahinhamza, rserranon

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

[yusufsahinhamza]

Concept ACK

[rserranon]

Concept ACK, Test ACK

[rserranon]

It is not clear to me why node2_addr is a send address, I tried to replicate it in regtest but all my new addresses are receive addresses, maybe is worth clarifying it.

[brunoerg]

node = self.nodes[0] -> so, node refers to self.nodes[0].

Here we are getting a new address from self.nodes[1], so it will receive btc using this address. For this reason, it can be used by self.nodes[0] to send Bitcoins.

So, node2_addr for self.nodes[1] is "receive" and for self.nodes[0] is "send".

[kristapsk]

ACK c467cff