Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Qt] allow users to set -onion via GUI #4587
As discussed in #2575 I'd like to simplify this to:
changed the title from
[Qt] allow users to set -proxy6 and -tor via GUI
[Qt] allow users to set -tor via GUI
Sep 23, 2014
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4587_776d006492d75c94cbff1edf7fae760f0a95ebcf/ for binaries and test log.
Gave it a short test.
Why can't i unselect/select the IPv4/IPv6/Tor checkboxes (i didn't start reading why in the PRs description because IMO this must be clear within the app). If it's just as a visual prove what networks are supported by the proxy, it should not use read-only checkboxes.
The new height of the settings window does somehow look strange on the other tabs.
IMO the autoresizing would be nice but should not hold this PR back.
@jonasschnelli I choose the read-only checkbox approach as that seemed easy to do. What elemet do you suggest? As you discovered the state is not changable via the boxes, they just give information.
The resize issue is a different one and as far as I understand the link you gave me, this is just for getting a nice and smooth animation, but I don't even know how to resize a window so that the contents and size are matching and that it looks good ;). IMHO our client suffers from these issue nearly everywhere.
Readonly-Checkboxes as visual indicator for a available option (but while actually supporting no interaction) should be avoided. But i can address this in another upcoming PR after merging.
I would recommend to use the checkmark icon instead (https://github.com/bitcoin/bitcoin/blob/master/src/qt/res/icons/transaction2.png).