[Qt] allow users to set -onion via GUI

[Diapolo]

• also allow users to see, if the default proxy (-proxy) is used for IPv6
  and Onion
• based on extend core proxy options and handling #4871 (formerly extend core proxy options and handling #2575)

[laanwj]

Looks good.

As discussed in #2575 I'd like to simplify this to:

• A clearnet proxy for IPv4 and IPv6 and name-based lookups (except *.onion, and possibly other 'darknet's in the future)
• A proxy for .onion. This defaults to the clearnet proxy *if the onion network is enabled at all.

[Diapolo]

@laanwj Removed the -proxy6 stuff and rebased on the recently updated core pull.

[BitcoinPullTester]

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4587_776d006492d75c94cbff1edf7fae760f0a95ebcf/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

[jonasschnelli]

Needs rebase or close due inactivity.

[Diapolo]

No, this needs review and help with #4871, which no one is interessted in :D.

[jonasschnelli]

Sorry. Your right. It's on top of #4871

[Diapolo]

Rebased to latest #4871 and fixed a small bug that was causing -onion to be missing in the options dialog, when the GUI setting was overridden.

[Diapolo]

Same here, this will be rebased after #6272 is merged.

[Diapolo]

Rebased and passing travis :).

[Diapolo]

@laanwj @jonasschnelli Mind taking a closer look now?

[Diapolo]

@jonasschnelli @laanwj This should be ready.

[jonasschnelli]

Gave it a short test.

Why can't i unselect/select the IPv4/IPv6/Tor checkboxes (i didn't start reading why in the PRs description because IMO this must be clear within the app). If it's just as a visual prove what networks are supported by the proxy, it should not use read-only checkboxes.

The new height of the settings window does somehow look strange on the other tabs.
Auto-Resizing like this (https://vid.me/F53C) would be a better approach (check: http://stackoverflow.com/questions/11441809/resize-window-using-qpropertyanimation).

IMO the autoresizing would be nice but should not hold this PR back.

[jonasschnelli]

[Diapolo]

@jonasschnelli I choose the read-only checkbox approach as that seemed easy to do. What elemet do you suggest? As you discovered the state is not changable via the boxes, they just give information.

The resize issue is a different one and as far as I understand the link you gave me, this is just for getting a nice and smooth animation, but I don't even know how to resize a window so that the contents and size are matching and that it looks good ;). IMHO our client suffers from these issue nearly everywhere.

[jgarzik]

ut ACK

Is this ready for merging? Blockers appear to be resolved.

[jonasschnelli]

Readonly-Checkboxes as visual indicator for a available option (but while actually supporting no interaction) should be avoided. But i can address this in another upcoming PR after merging.

I would recommend to use the checkmark icon instead (https://github.com/bitcoin/bitcoin/blob/master/src/qt/res/icons/transaction2.png).

[Diapolo]

@jonasschnelli I'd love to get this in or you could just add a commit to it. But I'd love to move forward.

[jonasschnelli]

Doesn't compile at the moment because of the recent "emit" changes (#6433).

[Diapolo]

@jonasschnelli fixed the emit problem.

[jonasschnelli]

I think this looks better.
Commit: jonasschnelli@3ae2434

[laanwj]

@jonasschhnelli I like what you're trying to do, but I'm not sure it's better:

• The checkbox icon is always black, also in themes that themselves have a black background
• It doesn't fit in with the rest of the UI (check styles are slightly different)

[laanwj]

Going to merge this as-is for now. You can improve it later.

[jonasschnelli]

ACK.