-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require ZMQ version 4.x and update/cleanup zmq docs #6736
Conversation
Signed-off-by: Johnathan Corgan <johnathan@corganlabs.com>
Signed-off-by: Johnathan Corgan <johnathan@corganlabs.com>
@@ -157,11 +157,11 @@ if test "x$enable_debug" = xyes; then | |||
if test "x$GCC" = xyes; then | |||
CFLAGS="$CFLAGS -g3 -O0" | |||
fi | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed on IRC, I'd prefer to not have the unnecessary whitespace changes here in sections you're otherwise not touching
utACK apart from unnecessary space changes in build system |
utACK. Suggested addition, add zeromq to the build-osx.md dependencies:
(installs ZMQ version 4.1.3 right now) |
Those changes all remove excess or invisible whitespace, which my editor does as a way of not introducing them in the first place. I'd rather not turn this feature off only when editing bitcoin source code. |
@gavinandresen I think there is an existing PR for that, I'll check. |
@jmcorgan I understand it's annoying to have to change editor settings per project. But unnecessary whitespace changes create more merge conflicts/rebases. This is acceptable for relatively seldom changing files like the documentation, but not for e.g. |
tangentially related: I have a fixed version of #6686 coming up, just doing a few tests first. |
There are docs illustrating how to remain compatible with the 2.x api here: http://zeromq.org/docs:3-1-upgrade Since there are obviously lots of 2.x/3.x libs still in the wild, I think it makes sense to try to support them instead. |
I'll leave it to the core-devs to decide what compatibility they want to introduce here. If previous API compatibility is desired, there will need to be code changes, and we'll start this process all over again. Alternatively, it could be accepted as-is, and if it turns out users want that, it could be changed at that point. |
@jmcorgan What do you mean by starting the process all over again? I've pushed a change here that fixes build with >=libzmq 2.2.0: theuni@a89a62f Verified that the rpc tests are successful. I also went through the rest of the API migration guide and verified that we don't violate any rules for API compatibility, so this really is just a matter of fixing builds. |
I mean code review, testing, etc. I've done it for ZMQ 4.x, but not the earlier ones. If the rpc tests are sufficient, then that's great. |
ut ACK |
ut ACK. Interesting that build notes slipped through. |
ab0b8be zmq: update and cleanup build-unix, release-notes, and zmq docs (Johnathan Corgan) 6cebd5d zmq: require version 4.x or newer of libzmq (Johnathan Corgan)
2.x support is something for a different pull and shouldn't hold up getting the documentation in order. I'm personally not sure it's worth it - |
Agreed with the PR split. May want to reconsider the setting, as being enabled by default might be construed as a "promise a version will work." |
Add ZeroMQ notifications Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6103 - bitcoin/bitcoin#6684 - bitcoin/bitcoin#6686 - bitcoin/bitcoin#6736 - bitcoin/bitcoin#6739 - bitcoin/bitcoin#6743 - bitcoin/bitcoin#6768 - bitcoin/bitcoin#6779 - bitcoin/bitcoin#6810 - bitcoin/bitcoin#6927 - bitcoin/bitcoin#6980 (only upgrading zeromq) - bitcoin/bitcoin#6680 - bitcoin/bitcoin#7058 - bitcoin/bitcoin#7621 - bitcoin/bitcoin#7335 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7853 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7762 - bitcoin/bitcoin#7993 (only upgrading zeromq) - bitcoin/bitcoin#8238 - bitcoin/bitcoin#8701 - bitcoin/bitcoin#6685 Closes #2020.
Add ZeroMQ notifications Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6103 - bitcoin/bitcoin#6684 - bitcoin/bitcoin#6686 - bitcoin/bitcoin#6736 - bitcoin/bitcoin#6739 - bitcoin/bitcoin#6743 - bitcoin/bitcoin#6768 - bitcoin/bitcoin#6779 - bitcoin/bitcoin#6810 - bitcoin/bitcoin#6927 - bitcoin/bitcoin#6980 (only upgrading zeromq) - bitcoin/bitcoin#6680 - bitcoin/bitcoin#7058 - bitcoin/bitcoin#7621 - bitcoin/bitcoin#7335 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7853 (only parts affecting `zmq_test.py`) - bitcoin/bitcoin#7762 - bitcoin/bitcoin#7993 (only upgrading zeromq) - bitcoin/bitcoin#8238 - bitcoin/bitcoin#8701 - bitcoin/bitcoin#6685 Closes #2020.
This PR changes the configure.ac to require ZMQ version 4.x or newer, which is provided on Debian and derivatives as package libzmq3-dev. It also updates the release notes, build-unix.md, and zmq.md docs to reflect this change and add missing documentation.
(Whitespace changes are purely trimming of extraneous previous whitespace by my editor.)