Master: Change the -keypool info text #7242
Conversation
Bump version from 0.11.99 to 0.12.0 so that we don't forget to do this when rc1 is released.
Remove necessity to call create_callback_map (as well as the function itself) from the Python P2P test framework. Invoke the appropriate methods directly. - Easy to forget to call it and wonder why it doesn't work - Simplifies the code - This makes it easier to handle new messages in subclasses Github-Pull: #7171 Rebased-From: 2f601d2
This is a combination of 3 commits. - Coinselection prunes extraneous inputs from ApproximateBestSubset A further pass over the available inputs has been added to ApproximateBestSubset after a candidate set has been found. It will prune any extraneous inputs in the selected subset, in order to decrease the number of input and the resulting change. - Moved set reduction to the end of ApproximateBestSubset to reduce performance impact - Added a test for the pruning of extraneous inputs after ApproximateBestSet Github-Pull: #4906 Rebased-From: 5c03483 af9510e fc0f52d
- Avoids string typos (by making the compiler check)
- Makes it easier to grep for handling/generation of a certain message type
- Refer directly to documentation by following the symbol in IDE
- Move list of valid message types to protocol.cpp:
protocol.cpp is a more appropriate place for this, and having
the array there makes it easier to keep things consistent.
Github-Pull: #7181
Rebased-From: 9bbe71b
We used to have a trickle node, a node which was chosen in each iteration of the send loop that was privileged and allowed to send out queued up non-time critical messages. Since the removal of the fixed sleeps in the network code, this resulted in fast and attackable treatment of such broadcasts. This pull request changes the 3 remaining trickle use cases by random delays: * Local address broadcast (while also removing the the wiping of the seen filter) * Address relay * Inv relay (for transactions; blocks are always relayed immediately) The code is based on older commits by Patrick Strateman. Github-Pull: #7125 Rebased-From: 5400ef6
Bring dependencies up to date with master: [depends] Boost 1.59.0 [depends] miniupnpc 1.9.20151026 [depends] native ccache 3.2.4 [depends] zeromq 4.0.7 [depends] Latest config.guess & config.sub [depends] Fix miniupnpc compilation on osx Github-Pull: #6980 Rebased-From: 9e940fa 17ad964 26f8ea5 10d3c77 23a3c47 e0769e1
…action 1) Fix mempool limiting for PrioritiseTransaction Redo the feerate index to be based on mining score, rather than fee. Update mempool_packages.py to test prioritisetransaction's effect on package scores. 2) Update replace-by-fee logic to use fee deltas 3) Use fee deltas for determining mempool acceptance 4) Remove GetMinRelayFee One test in AcceptToMemoryPool was to compare a transaction's fee agains the value returned by GetMinRelayFee. This value was zero for all small transactions. For larger transactions (between DEFAULT_BLOCK_PRIORITY_SIZE and MAX_STANDARD_TX_SIZE), this function was preventing low fee transactions from ever being accepted. With this function removed, we will now allow transactions in that range with fees (including modifications via PrioritiseTransaction) below the minRelayTxFee, provided that they have sufficient priority. Github-Pull: #7062 Rebased-From: eb30666 9ef2a25 27fae34 901b01d
|
I think you need to rebase against master or clean up your git history. |
|
I'd prefer not putting the extra text in the parenthesis. It has nothing to do with the default and looks circuitous. Maybe: Also: pull requests should be against master, not 0.12 |
bom64
changed the title
|
The trigger for this issue was that I was use -keypool when the wallet.dat exist but there was no message at all that the wallet.dat was unchanged. It was only because I was monitor the size of wallet.dat that I was realise that notting happen. I error message will be nice a la: Right now notting happen at all. No message or warning to the user. I am not sure about: |
I understand, makes sense to add this statement. I have to close this PR though, please create a new pull that starts from master instead of the 0.12 branch. |
|
@bom64 https://www.google.com/#q=git+101 Might come in handy. ;) |
|
Yes! :-) But more generel: User input have to be more easy. |
Current:
Set key pool size to (default: %u),
New maybe something like:
Set key pool size to (default: %u, does not refill keypool if wallet already exists).