Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sqlite-bundled feature #566

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Add sqlite-bundled feature #566

merged 1 commit into from
Mar 30, 2022

Conversation

notmandatory
Copy link
Member

Description

Add sqlite-bundled feature for deployments that need a bundled version of sqlite, ie. for mobile platforms. This feature enables the rusqlite bundled feature.

Notes to the reviewers

The bundled version of sqlite is required for cross-compiling bdk with sqlite for mobile devices because we don't have the sqlite lib to link to for the mobile platforms. Using the bundled feature builds and links a recent version of sqlite.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

@notmandatory notmandatory self-assigned this Mar 12, 2022
@codecov
Copy link

codecov bot commented Mar 12, 2022 •
edited
Loading

Codecov Report

Merging #566 (6614ff7) into master (3334c8d) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 6614ff7 differs from pull request most recent head c6eeb7b. Consider uploading reports for the commit c6eeb7b to get more accurate results

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
- Coverage   73.26%   73.26%   -0.01%     
==========================================
  Files          35       35              
  Lines        7586     7581       -5     
==========================================
- Hits         5558     5554       -4     
+ Misses       2028     2027       -1
Impacted Files Coverage Δ
src/database/memory.rs 79.60% <0.00%> (-0.14%) ⬇️
src/types.rs 93.54% <0.00%> (-0.07%) ⬇️
src/database/mod.rs 99.21% <0.00%> (ø)
src/wallet/tx_builder.rs 91.42% <0.00%> (ø)
src/wallet/coin_selection.rs 96.60% <0.00%> (ø)
src/blockchain/script_sync.rs 0.00% <0.00%> (ø)
src/blockchain/compact_filters/mod.rs 0.00% <0.00%> (ø)
src/wallet/mod.rs 96.54% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3334c8d...c6eeb7b. Read the comment docs.

@notmandatory notmandatory mentioned this pull request Mar 12, 2022
Merged
notmandatory added a commit to bitcoindevkit/bdk-ffi that referenced this pull request Mar 14, 2022
@notmandatory
Merge #116: Add sqlite database support
4fc9fb9 
12f4784 Add sqlite database option (Steve Myers)

Pull request description:

  ### Description

  Add sqlite db database option.

  ### Notes to the reviewers

  When bitcoindevkit/bdk#566 is released we need to updated this project to use the `sqlite-packaged` feature, see TODO in Cargo.toml.

ACKs for top commit:
  thunderbiscuit:
    Tested ACK [12f4784](12f4784).

Tree-SHA512: c39472507596e036dd81c22a05d424c6d363545b1a8bd622bf9647967b1b86ab44764da1a15169ac542c80a62a79331b5abcda7b657cc28d93ffdda51a62bd6e
rajarshimaitra
rajarshimaitra approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6614ff7

@notmandatory notmandatory marked this pull request as ready for review March 22, 2022 15:05
rajarshimaitra
rajarshimaitra reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReACK c6eeb7b

@notmandatory notmandatory merged commit 06b80fd into bitcoindevkit:master Mar 30, 2022
@notmandatory notmandatory deleted the sqlite_bundled branch October 24, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajarshimaitra rajarshimaitra rajarshimaitra approved these changes

Assignees

@notmandatory notmandatory

Labels
module-database
Projects
BDK Maintenance
Archived in project
Milestone
Release 0.18.0 Feature Freeze
Development

Successfully merging this pull request may close these issues.
2 participants
@notmandatory @rajarshimaitra