Skip to content

Conversation

ValuedMammal
Copy link
Collaborator

Backports #300 adding the persist_test_utils module to the release/2.2 branch.

Checklists

All Submissions:

Added the following functions:-
  - `persist_wallet_changeset`: tests if each field of wallet ChangeSet
  is persisted.
  - `persist_multiple_wallet_changesets`: tests if multiple wallets can
  be persisted in a single file.
  - `persist_network`: tests if network is persisted
  - `persist_keychains`: tests if descriptors are persisted
  - `persist_single_keychain`: tests if descriptor in single keychain
  wallet is persisted.
Used persist_test_utils to test WalletPersister impl of file_store and
rusqlite.
@ValuedMammal ValuedMammal added the release Release related issue or PR label Sep 20, 2025
@ValuedMammal ValuedMammal added this to the Wallet 2.2.0 milestone Sep 20, 2025
@ValuedMammal ValuedMammal moved this to Needs Review in BDK Wallet Sep 20, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17879873301

Details

  • 214 of 256 (83.59%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 84.88%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wallet/src/persist_test_utils.rs 214 256 83.59%
Totals Coverage Status
Change from base Build 17554145933: -0.04%
Covered Lines: 6888
Relevant Lines: 8115

💛 - Coveralls

Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK b642284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release related issue or PR
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

4 participants