Refactoring extractInput and __build to enable nested scripts
#540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubensayshi
force-pushed
the
segwit-prep
branch
from
90d4ac1 to
cd72141
Compare
|
|
||
| // Ignore empty scripts | ||
| if (txIn.script.length === 0) return {} | ||
|
|
There was a problem hiding this comment.
moved this into extractInput so in the future it can first check if it's segwit
rubensayshi
force-pushed
the
segwit-prep
branch
from
cd72141 to
e583014
Compare
|
|
||
| // ready to sign? | ||
| var signatureScript = input.redeemScript || input.prevOutScript | ||
| signatureScript = signatureScript || input.redeemScript || input.prevOutScript |
There was a problem hiding this comment.
preperation for segwit, where the signatureScript could be different from the redeemScript
rubensayshi
force-pushed
the
segwit-prep
branch
from
e583014 to
f6ef01f
Compare
| if (allowIncomplete) { | ||
| for (var i = 0; i < msSignatures.length; ++i) { | ||
| msSignatures[i] = msSignatures[i] || ops.OP_0 | ||
| var processScript = function (scriptType, parentType, redeemScript) { |
There was a problem hiding this comment.
moved into a function so that we can call it again for nested scripts (P2SH[ P2WSH[ P2PKH / multsig ] ])
20 tasks
rubensayshi
force-pushed
the
segwit-prep
branch
from
f6ef01f to
122a86d
Compare
rubensayshi
changed the title
extractInputs and __build to enable nested scriptsextractInput and __build to enable nested scripts
|
|
rubensayshi
force-pushed
the
segwit-prep
branch
from
122a86d to
867065b
Compare
|
Needs rebase. |
…2SH[ P2PKH / multsig ]`). This is preperation for the segwit support which will have `P2SH[ P2WSH[ P2PKH / multsig ] ]` scripts
rubensayshi
force-pushed
the
segwit-prep
branch
from
867065b to
7aaae4c
Compare
dcousens
added a commit
that referenced
this pull request
Feb 25, 2016
Refactoring `extractInput` and `__build` to enable nested scripts
|
@rubensayshi can you work from within this repository if possible? It makes collaboration easier :) |
dcousens
added a commit
that referenced
this pull request
Apr 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preperation for the segwit support which will have
P2SH[ P2WSH[ P2PKH / multsig ] ]scripts.It's only refactoring code, shouldn't contain any function changes and should make the #520 PR easier to diff once merged.
Considering the following possible scripts we want to support: https://gist.github.com/rubensayshi/fbe39657e90ef416d411