Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lighthouse crossing beam #1025

Closed
knmcguire opened this issue Apr 19, 2022 · 0 comments · Fixed by #1071
Closed

lighthouse crossing beam #1025

knmcguire opened this issue Apr 19, 2022 · 0 comments · Fixed by #1071
Milestone

Comments

@knmcguire
Copy link
Contributor

The crossing beam method is no longer used as default as lighthouse measurement, but is used as ground truth measurement (CONFIG_DECK_LIGHTHOUSE_AS_GROUNDTRUTH). Looking at the delta value, where 0 means that the measurement of lighthouse.x/y/z is invalid, a lot of crossing beam measurements are lost as soon as the crazyflie moves further than 4 meters from one basestation, eventhough it probably still receives solid angles on the others. This if statement put's it to 0 as soon as one sensor has not received a measurement, which is something that will probably occur a lot if the crazyflie flies further out of range of one basestation. Also the averaging in that same ifstatement suggest that the position of just one sensor can already be used for position estimate.

I also discussed with @whoenig that we should remove the averaging and base this on the sensor position instead, or the standard deviation is not really accurate anymore.

Also it seems that we are not using the CONFIG_DECK_LIGHTHOUSE_AS_GROUNDTRUTH to prevent the yaw estimate of the crossing beam getting to the kalman filter, which is probably good to implement as well.

Anyway, it would be worth to fix this at one point and make the crossing beam still a reliable method for ground truth measurements!

@knmcguire knmcguire linked a pull request Jun 28, 2022 that will close this issue
krichardsson added a commit that referenced this issue Jun 28, 2022
add GT define to all lighthouse measurements fix #1025
@krichardsson krichardsson added this to the 2022.09 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants