Remove tilt compensation #1019
Merged
Remove tilt compensation #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove sensfusion6GetInvThrustCompensationForTilt and the single use of it in controller_pid.c (which was disabled by default) * While tilt compensation might be useful, its current implementation does not seem to be correct in the first place (since it does not rely on the actual tilt of the quadrotor) * As discussed in bitcraze#1017, it might be best to remove the feature and re-add it properly later, if the need arises.
knmcguire
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of it in controller_pid.c (which was disabled by default)
does not seem to be correct in the first place (since it does not
rely on the actual tilt of the quadrotor)
re-add it properly later, if the need arises.