fix: fix unit tests on arm64 #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the unit tests on
arm64CPUs (e.g., Apple Silicon). There are two fixes worth mentioning:uint32_tinto afloatmight result in loss of precision as floats cannot represent all integers above 2^23-1.arm64,sizeof(uint32_t) != sizeof(unsigned long)(unsigned longs are 8 byte, at least on Apple Silicon), so callingeprintfwith anuint32_twhere the corresponding format specifier is%luis incorrect; the function would take 8 bytes from the stack and print a different number. This is now fixed.