Fixed estimator position stuck when no connection to client #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR addresses the problem of locking the kalman estimator if the estimator is reset multiple times when not connected to a client. This could, for instance happen if no positioning system was present which let to the kalman supervisor resetting the kalman filter repeatedly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
paramSetInt()andparamSetFloat()while having no connection to the client established leads to the output queue being filled up and the position being stuck after the resetting of the Kalman estimator. This can be handled by setting the CONFIG_PARAM_SILENT_UPDATES flag and the user should be careful when using these functions.