-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi bs non experimental #1092
Conversation
Firmware compiled with 4:
compared to when compiling for 2:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only worry is what happens in a LH1 system that only supports 2 base stations.
- Does the code work for LH1 when set to 4 base stations?
- I suppose the client will show 4 base stations also for LH1, is that OK?
If we would need to change it further in the firmware, it will be either changing all DECK_LIGHTHOUSE_MAX_N_BS to a variable or we do something with the baseStationAvailabledMap parameter?
The problem is that it is only being set and used in the lighthouseCoreInit()
Maybe we can continously modify the bit everytime the lighthouse type switched: crazyflie-firmware/src/modules/src/lighthouse/lighthouse_core.c Lines 180 to 188 in 59044ce
|
Tried this in the client and it does not work... bitcraze/crazyflie-clients-python#623 Read only params and get_param is not meant for this functionality so I will need to turn it into a logging variable as well (since the param one is a core variable). Let's see how it goes. |
This PR does two things