Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added BaseSyncWorker #284

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Added BaseSyncWorker #284

merged 6 commits into from
Apr 29, 2024

Conversation

ArnyminerZ
Copy link
Member

No description provided.

@ArnyminerZ
Added BaseSyncWorker
e2284a6 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the refactoring Quality improvement of existing functions label Apr 12, 2024
@ArnyminerZ ArnyminerZ requested a review from sunkup April 12, 2024 09:57
@ArnyminerZ ArnyminerZ self-assigned this Apr 12, 2024
@ArnyminerZ ArnyminerZ linked an issue Apr 12, 2024 that may be closed by this pull request
Refactor for a generic BaseSyncWorker #283
Closed
@ArnyminerZ ArnyminerZ marked this pull request as ready for review April 12, 2024 09:57
sunkup
sunkup requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CalendarToRoomMigrationTest still references SyncWorker.ONLY_MIGRATE but the constant is now in BaseSyncWorker

@ArnyminerZ
Fixed test
5a02c58 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ requested a review from sunkup April 15, 2024 08:27
@sunkup sunkup added this to the 2.2.2 milestone Apr 15, 2024
sunkup
sunkup requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seems to work :)

I am sorry for the version release confusion. Can you rebase/merge with dev once more? There seem to be conflicts with #279

After that I will review only the changes and we can merge this ~

@ArnyminerZ
Merge branch 'dev' into 283-refactor-for-a-generic-basesyncworker
bd25697 
# Conflicts:
#	app/src/main/java/at/bitfire/icsdroid/SyncWorker.kt
@ArnyminerZ
Optimized imports
d5bb5fb 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ requested a review from sunkup April 28, 2024 08:27
@ArnyminerZ
Fixed suspensions
5f19e6f 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ
Disabled deprecation
929a380 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@sunkup sunkup merged commit dffddc7 into dev Apr 29, 2024
7 checks passed
@sunkup sunkup deleted the 283-refactor-for-a-generic-basesyncworker branch April 29, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Quality improvement of existing functions
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.

Refactor for a generic BaseSyncWorker
2 participants
@ArnyminerZ @sunkup