routed links must descend from pushstate root

[stevenvachon]

If we have:

can.route.bindings.pushstate.root = "/bitovi/src/app/";

and a link like:

<a href="/bitovi/test/"></a>

When that link is clicked on, it will call ev.preventDefault() and do a pushState() instead of letting the link behave normally.

---

Additionally, if we have the same root listed above and:

<a href="/bitovi/src/app/test/"></a>
<!-- or -->
<a href="test/"></a>

can.route.deparam treats "/bitovi/src/app/" (the root) as part of the route when it shouldn't.

[justinbmeyer]

What is the issue exactly? I'm not sure what your test code does because it's only logging things and I don't know where the fail assertion should be. Given your description:

If you have a pushstate root of "/app/" and you have a link within your app pointing to "/other/", it is currently be treated as a route in v2.0.4 because the host is the same.

Are you saying that if I have:

can.route.bindings.pushstate.root = "/bitovi/src/app/";

and a link like:

<a href="/bitovi/test/"></a>

When that link is clicked on, it will call ev.preventDefault() and do a pushState() instead of letting the link behave like normal?

If yes, that is certainly a bug.

[stevenvachon]

Yes, exactly. I have a fix for it, though. And an additional fix will also avoid the issue I was having which led me to write #644. I've edited my original post above.

[stevenvachon]

I am never using issue/PR numbers in a commit message ever again.

[justinbmeyer]

Why? They are very useful.

[stevenvachon]

When we do a git rebase -i and git push -f, Github will nicely remove any previous commits on the PR, but not if those commits have messages containing references to an issue/PR. Like the 3 above. I've emailed Github about it, though and perhaps they'll implement a new feature in the near future.

[daffl]

Needs .stop() and .start() or .asyncTest for asynchronous tests.

[daffl]

Scratch that. Looks good.

[daffl]

@justinbmeyer Can you sanity check this? Looks good to merge to me but I haven't worked with the pushstate implementation a lot.

[justinbmeyer]

@andykant where did you get on fixing this? This is breaking minor.

[justinbmeyer]

This test is still breaking for me in firefox.