hot fix for react component prop having same name as an html attribute #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherjbaker
approved these changes
Feb 21, 2023
christopherjbaker
pushed a commit
that referenced
this pull request
Apr 3, 2023
* begin convert to ts (#49) * begin convert to ts * get rid of npmignore because we added files to package json * wip * wip too * simplify tsconfig include path * r2wc11: support preact v10 (#51) * Allow specifying prop types with automatic type casting from attr value string into the underlying React component. Remove propTypes requirement. (#50) * for: (R2WC-19) - allow 'on-*' and 'handle-*' attrs to reference global functions and pass the fn to the underlying react component instead * for: (R2WC-17) remove propTypes dep, add attr to prop type casting option, bind Function params to the webcomponent instance * for: (R2WC-20) allow React ref prop types * for: (R2WC-22) upgrade tests to allow waiting until it's ready without arbirary setTimeout durations and enable useful console logging when they fail since vitest (jest) expectations can't have notes attached normally (#53) * for: (R2WC-23) use functional components in api docs and ensure they work with tests (#54) * adding upgraded publish.yml for prereleases (#55) * Publish v2.0.0-alpha.0 * support children prop (#57) * support children prop * fix attributes and preact test * Update react-to-webcomponent.test.jsx Co-authored-by: Christopher Baker <christopher@hmudesign.com> * Bump json5 from 2.2.1 to 2.2.3 (#64) Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.1...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist and http-server (#70) Bumps [minimist](https://github.com/minimistjs/minimist) to 1.2.6 and updates ancestor dependency [http-server](https://github.com/http-party/http-server). These dependencies need to be updated together. Updates `minimist` from 0.0.10 to 1.2.6 - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v0.0.10...v1.2.6) Updates `http-server` from 0.11.2 to 14.1.1 - [Release notes](https://github.com/http-party/http-server/releases) - [Commits](http-party/http-server@v0.11.2...v14.1.1) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect - dependency-name: http-server dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ecstatic and http-server (#69) Removes [ecstatic](https://github.com/jfhbrook/node-ecstatic). It's no longer used after updating ancestor dependency [http-server](https://github.com/http-party/http-server). These dependencies need to be updated together. Removes `ecstatic` Updates `http-server` from 0.11.2 to 14.1.1 - [Release notes](https://github.com/http-party/http-server/releases) - [Commits](http-party/http-server@v0.11.2...v14.1.1) --- updated-dependencies: - dependency-name: ecstatic dependency-type: indirect - dependency-name: http-server dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update publish.yml * Update publish.yml * hot fix for react component prop having same name as an html attribute (#74) * hot fix for react component prop having same name as an html attribute * test fix * improved typing and resolving existing typing issues (#84) * improved typing * react and react-dom mock types * prettier formatting * slight typing changes * specific return type for r2wc function * type support for class components * moved R2WCOptions to global.d.ts --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jane <92131113+janebitovi@users.noreply.github.com> Co-authored-by: Youssef A <youssef@bitovi.com> Co-authored-by: [bot]@workflow <Workflow: [bot]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bavin Edwards <65621465+zerico007@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved this to set property on both the React component and the HTML element if name is the same