This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Testnet addresses were returning false for isValid #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was called. I think that testnet addresses should return true under this scenario, and regtest addresses should only be valid when the network is expected to be regtest
micahriggan
force-pushed
the
feature/fix-testnet-addr
branch
from
60ba1bd to
0cdd7d2
Compare
matiu
approved these changes
Mar 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when enableRegtest was called. I think that testnet addresses should return true under this scenario, and regtest addresses should only be valid when the network is expected to be regtest