add getDifficulty method to BlockHeader #1331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnagurny
changed the title
lib/block/blockheader.js
Outdated
There was a problem hiding this comment.
Docs need to be updated with the new first argument.
pnagurny
force-pushed
the
feature/difficulty
branch
from
3d6f3e4 to
d449906
Compare
lib/block/blockheader.js
Outdated
There was a problem hiding this comment.
It should noted that this is optional, and will default to the bits of livenet and testnet genesis bits.
There was a problem hiding this comment.
Also, the test case for passing in the bits isn't covered. I don't currently see a need for the argument yet, so another option would be to remove the argument, and we can add if needed later.
pnagurny
force-pushed
the
feature/difficulty
branch
2 times, most recently
from
f743ee5 to
0877746
Compare
pnagurny
force-pushed
the
feature/difficulty
branch
from
0877746 to
c86f1a9
Compare
|
Travis CI seems to not be running the tests, however I've run all the tests in Node.js v0.12 and v0.10 and iojs, and everything is passing. |
|
ACK |
braydonf
pushed a commit
that referenced
this pull request
Sep 8, 2015
add getDifficulty method to BlockHeader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.