Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push settle_order changes if subscribed to market #747

Merged
merged 2 commits into from
Mar 20, 2018

Conversation

abitmore
Copy link
Member

PR for #745 .

Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this seems to work. i did some testing while replaying as follows:

{"method": "call", "params": [0, "subscribe_to_market", [1, "1.3.0", "1.3.113"]], "id": 4}

and i was able to catch a 1.4.X object:

...
< {"method":"notice","params":[1,[[{"id":"1.8.1243","borrower":"1.2.31137","collateral":"79992216216","debt":60000000,"call_price":{"base":{"amount":"3333009009","asset_id":"1.3.0"},"quote":{"amount":4375000,"asset_id":"1.3.113"}}}]]]}
< {"method":"notice","params":[1,[[{"id":"1.4.51","owner":"1.2.31137","balance":{"amount":60000000,"asset_id":"1.3.113"},"settlement_date":"2015-12-05T06:27:36"}]]]}
< {"method":"notice","params":[1,[[{"id":"1.8.1016","borrower":"1.2.36022","collateral":"2300000000000","debt":1900000000,"call_price":{"base":{"amount":92000,"asset_id":"1.3.0"},"quote":{"amount":133,"asset_id":"1.3.113"}}}]]]}
...

I think it will be good to have a test case, actually the whole subscription system need to have test cases(in another issue). Test cases will allow to create operations and see if they are broadcasted throw the socket, will allow us to check the bloom filter from client perspective and how is performing.

this pull is ok, will not break anything it seems but really think test cases for WS are needed.

@oxarbitrage oxarbitrage merged commit 10e4d7f into develop Mar 20, 2018
@abitmore abitmore deleted the 745-push-settle-order branch March 20, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants