Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1] [rrandom] Clicking EXCHANGE defaults to "bitUSD : BTS" if Already in Exchange #211

Closed
landry314 opened this issue Jul 24, 2017 · 4 comments
Closed

[1] [rrandom] Clicking EXCHANGE defaults to "bitUSD : BTS" if Already in Exchange #211

landry314 opened this issue Jul 24, 2017 · 4 comments
Assignees
@wmbutler
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Milestone
170901

Comments

@landry314
Copy link

landry314 commented Jul 24, 2017 •
edited
Loading

I am almost always using BTS : bitCNY and it stays as the default for me as I change tabs and move around the GUI but if I accidentally click on EXCHANGE at the top WHILE I am already in the exchange area then it switches to "bitUSD : BTS". Why this is the default, I don't know.

The expected behavior for a GUI when you click into somewhere you already are is to DO NOTHING. To change the pair to another pair is unexpected and annoying because every time I do this I need to find my pair again. It wastes time and is not clean programming: there is no reason to assume I would want to switch to bitUSD : BTS.
@landry314 landry314 changed the title clicking exchange defaults to bitusd when alread in exchange Clicking EXCHANGE defaults to BITUSD : BTS if Already in Exchange Jul 24, 2017
@landry314 landry314 changed the title Clicking EXCHANGE defaults to BITUSD : BTS if Already in Exchange Clicking EXCHANGE defaults to "bitUSD : BTS" if Already in Exchange Jul 24, 2017
@wmbutler wmbutler added the [3] Bug Classification indicating the existing implementation does not match the intention of the design label Jul 24, 2017
@wmbutler
Copy link
Contributor

If in exchange already remain on same trading pair.

@Ashaman-
Copy link
Contributor

Ashaman- commented Jul 27, 2017 •
edited
Loading

I only observe this after a wallet reload. Otherwise switching between exchange and other tabs returns me to the last trading pair I had open - BTS:bitCNY.

Edit: Ignore that. I misread the issue. You're absolutely right. Click on exchange when already in exchange...

@wmbutler wmbutler changed the title Clicking EXCHANGE defaults to "bitUSD : BTS" if Already in Exchange [1] Clicking EXCHANGE defaults to "bitUSD : BTS" if Already in Exchange Aug 4, 2017
@wmbutler wmbutler added this to the 170901 milestone Aug 4, 2017
@rrandom
Copy link
Contributor

rrandom commented Aug 15, 2017

Hi, I could take this issue

@wmbutler wmbutler self-assigned this Aug 15, 2017
@wmbutler
Copy link
Contributor

The bounty is for 1 hour. Assigned to @rrandom. Thanks!

@wmbutler wmbutler changed the title [1] Clicking EXCHANGE defaults to "bitUSD : BTS" if Already in Exchange [1] [rrandom]Clicking EXCHANGE defaults to "bitUSD : BTS" if Already in Exchange Aug 15, 2017
@wmbutler wmbutler changed the title [1] [rrandom]Clicking EXCHANGE defaults to "bitUSD : BTS" if Already in Exchange [1] [rrandom] Clicking EXCHANGE defaults to "bitUSD : BTS" if Already in Exchange Aug 15, 2017
@rrandom rrandom mentioned this issue Aug 16, 2017
Merged
@svk31 svk31 closed this as completed in 6b737b2 Aug 16, 2017
rrandom added a commit to rrandom/bitshares-ui that referenced this issue Aug 21, 2017
@rrandom
Fix issue bitshares#211 (bitshares#271)
5af77a5 
* remains last trading pair when in exchange page

* add default trade pair for new users

Close bitshares#211
@snyk-bot snyk-bot mentioned this issue Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wmbutler wmbutler

Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Projects
None yet
Milestone
170901
Development

No branches or pull requests
4 participants
@rrandom @wmbutler @Ashaman- @landry314