Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.5][happyconcepts] Remove Trollbox #289

Closed
wmbutler opened this issue Aug 18, 2017 · 12 comments
Closed

[1.5][happyconcepts] Remove Trollbox #289

wmbutler opened this issue Aug 18, 2017 · 12 comments
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Milestone

Comments

@wmbutler
Copy link
Contributor

Based upon votes on #281

@wmbutler wmbutler added the [3] Feature Classification indicating the addition of novel functionality to the design label Aug 18, 2017
@wmbutler wmbutler added this to the 170914 milestone Aug 18, 2017
@happyconcepts
Copy link
Contributor

happyconcepts commented Aug 18, 2017 via email

@happyconcepts
Copy link
Contributor

So I would like to claim this, it is marked for the 170914 sprint. Thank you.

@wmbutler wmbutler changed the title [1] Remove Trollbox [1][happyconcepts] Remove Trollbox Aug 21, 2017
@wmbutler
Copy link
Contributor Author

@happyconcepts it's yours but the issue specifically states it's for removal only. A separate issue can be opened at a later date for a new feature. This PR will only be paid for removal.

@o5j5vg55bv5hv5j5f8799f9

Can the trollbox be done on chain to allow global platform communication with fee cost of course. and not random UI specific chat? Possibly reserved for important announcements that way. Fees can go towards development.

@btsfav
Copy link

btsfav commented Aug 23, 2017

please add a link to discord too: https://discord.gg/GsjQfAJ

@wmbutler wmbutler changed the title [1][happyconcepts] Remove Trollbox [1.5][happyconcepts] Remove Trollbox Aug 23, 2017
@wmbutler
Copy link
Contributor Author

Added .25 to have this added to discord as well @happyconcepts

@wmbutler wmbutler changed the title [1.5][happyconcepts] Remove Trollbox [1.25][happyconcepts] Remove Trollbox Aug 23, 2017
@happyconcepts
Copy link
Contributor

I have removed the trollbox locally and it tests fine; my plan is to submit the PR later today.
....but where exactly would you like the discord link? For now I just added it to the readme.

@btsfav
Copy link

btsfav commented Aug 23, 2017

@happyconcepts check how its done @ bitshares.org/wallet

@wmbutler
Copy link
Contributor Author

I think it's fine. Disabling the trollbox from a security/stability standpoint was my biggest concern.

@svk31
Copy link
Contributor

svk31 commented Aug 23, 2017

So what exactly is this issue for? The trollbox is already disabled in the code and has been for a long time.

@happyconcepts
Copy link
Contributor

happyconcepts commented Aug 23, 2017 via email

@wmbutler wmbutler modified the milestones: 170901, 170914 Aug 24, 2017
@wmbutler wmbutler changed the title [1.25][happyconcepts] Remove Trollbox [1.5][happyconcepts] Remove Trollbox Aug 24, 2017
@wmbutler
Copy link
Contributor Author

Updated to 1.5 and thanks for removal.

svk31 pushed a commit that referenced this issue Aug 24, 2017
* Update README.md

* Added discord link
happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Aug 24, 2017
happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Aug 25, 2017
happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Aug 25, 2017
happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Aug 25, 2017
happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Aug 26, 2017
@svk31 svk31 closed this as completed in d418b8f Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Projects
None yet
Development

No branches or pull requests

5 participants