-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.5][happyconcepts] Remove Trollbox #289
Comments
Please consider repurposing trollbox window functionality instead of
throwing it away.
That anchored window popup could be a useful way to deliver error messages
to users, for example.
Plus I liked seeing how many other people were online ...
Please!
On Aug 18, 2017 7:50 AM, "Bill Butler" <notifications@github.com> wrote:
Based upon votes on #281
<#281>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#289>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANfZLCLeBUPa8mVzBbI_bZXbjKHvLNh1ks5sZaSggaJpZM4O7qA_>
.
|
So I would like to claim this, it is marked for the 170914 sprint. Thank you. |
@happyconcepts it's yours but the issue specifically states it's for removal only. A separate issue can be opened at a later date for a new feature. This PR will only be paid for removal. |
Can the trollbox be done on chain to allow global platform communication with fee cost of course. and not random UI specific chat? Possibly reserved for important announcements that way. Fees can go towards development. |
please add a link to discord too: https://discord.gg/GsjQfAJ |
Added .25 to have this added to discord as well @happyconcepts |
I have removed the trollbox locally and it tests fine; my plan is to submit the PR later today. |
@happyconcepts check how its done @ bitshares.org/wallet |
I think it's fine. Disabling the trollbox from a security/stability standpoint was my biggest concern. |
So what exactly is this issue for? The trollbox is already disabled in the code and has been for a long time. |
I took the further step, to remove dependencies for it and remove the react
component. It seemed the logical way to fulfill the requirement e.g.
"Remove trollbox"
So there is no place to put a discord link. But if you will keep it
bountied at 1.5 I think that is more realistic for the task. This can even
push with the Sept 1 release, as its ready.
…On Aug 23, 2017 11:43 AM, "Sigve Kvalsvik" ***@***.***> wrote:
So what exactly is this issue for? The trollbox is already disabled in the
code and has been for a long time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#289 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANfZLP-fnQGlySTD0e-1YHt_MTtxKKwMks5sbHK2gaJpZM4O7qA_>
.
|
Updated to 1.5 and thanks for removal. |
Based upon votes on #281
The text was updated successfully, but these errors were encountered: