Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit offer field max limits (field validation) #3533

Closed
grctest opened this issue Aug 18, 2022 · 1 comment · Fixed by #3594
Closed

Credit offer field max limits (field validation) #3533

grctest opened this issue Aug 18, 2022 · 1 comment · Fixed by #3594

Comments

@grctest
Copy link
Contributor

grctest commented Aug 18, 2022

Describe the bug
Entering a large enough number in several of the field will cause the following errors like: Uncaught Error ... cause: overflow

To Reproduce
Steps to reproduce the behavior:
Go to credit offer
Click on create or edit for credit offer modal
Enter too large a number for % rate (10000000000) and too large a number for minimum (a large number exceeding the borrow quantity)
Hit submit, see unhandled errors in console.

Expected behavior
Limit these fields, catch errors

Desktop (please complete the following information):

  • OS: windows
  • Browser: firefox
@grctest
Copy link
Contributor Author

grctest commented Aug 30, 2022

There's no warnings regarding applying an impossible fee like 5% on an asset with quantity 1 and precision 0 (an NFT) which could guarantee a default.

EBA's issued supply can grow/shrink based on deposits, so what may seem impossibly excessive could be resolved through an additional deposit.

@grctest grctest changed the title Credit offer field max limits Credit offer field max limits (bugs & vulnerability) Sep 22, 2022
@grctest grctest changed the title Credit offer field max limits (bugs & vulnerability) Credit offer field max limits (field validation) Oct 3, 2022
ihorml added a commit to ihorml/bitshares-ui that referenced this issue Nov 23, 2022
ihorml added a commit to ihorml/bitshares-ui that referenced this issue Nov 30, 2022
gades pushed a commit to piratecash/pirate-dex that referenced this issue Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant