Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Show list of open debt positions for smartcoin assets and warn when a position is at risk of force settlement #430

Closed
Ashaman- opened this issue Sep 20, 2017 · 12 comments
Assignees
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Milestone

Comments

@Ashaman-
Copy link
Contributor

The only way that I am aware of to view the complete list of open debt positions ordered by collateral ratio is cryptofresh - I dont think this functionality is implemented in bitshares-exlorer yet. Knowing the open debt positions is very important for borrowers of smartcoins when there are force settlement orders open on the books, since their exposure to the possible risk of forced settlement is directly related to how many less collateralized positions than theirs exist. Users should be able to view the list of open debt positions and their respective collateral ratios directly in the wallet software.

On the account page where it lists open debt positions, I think it should be possible to view the sum of debt positions with a lower collateral ratio than theirs (ie. rolling the mouse over collateral ratio could reveal that there are 1,223,523 bitUSD with a lower collateral ratio than yours). When a position is at risk of being force settled by a settle order on the books by being within its direct reach, the UI in Account should reflect that with a warning similar to the one that alerts you of a dangerously low collateral ratio.

@wmbutler wmbutler added the [3] Enhancement Classification indicating a change to the functionality of the existing imlementation label Sep 21, 2017
@landry314
Copy link

landry314 commented Sep 21, 2017

Yes, I use this link all the time to view open debt positions in bitCNY:
http://stage.cryptofresh.com/a/CNY

I think it would be great to have this integrated into the Explorer within the GUI. Currently, there is not enough useful information in there under Explorer -> Assets -> SmartCoins -> CNY .

@wmbutler wmbutler added this to the 171015 milestone Sep 23, 2017
@wmbutler wmbutler self-assigned this Sep 23, 2017
@wmbutler
Copy link
Contributor

I'll UX This.

@wmbutler wmbutler added [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive and removed [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive labels Oct 1, 2017
@wmbutler
Copy link
Contributor

wmbutler commented Oct 5, 2017

From cryptofresh to begin UX:

screen shot 2017-10-05 at 1 48 49 am

@wmbutler
Copy link
Contributor

wmbutler commented Oct 5, 2017

Latest table display:

screen shot 2017-10-05 at 1 49 57 am

@wmbutler
Copy link
Contributor

wmbutler commented Oct 5, 2017

Current Asset Screen:

screen shot 2017-10-05 at 1 51 16 am

@wmbutler
Copy link
Contributor

wmbutler commented Oct 5, 2017

I think we should use our new table layout with the tabs at the top to handle this. Of course, there is a technical component to this. It's possible cryptofresh is doing some extra caching to enable this display, but if it is technically possible to gather the data, I'd suggest we handle it the same way we do the user dashboard with tabs:

Price Feeds | Debt Positions

screen shot 2017-10-05 at 2 04 54 am

Obviously no need for dollar values. This screenshot is just to help convey the tabs comment above.

@wmbutler wmbutler modified the milestones: 171015, 171101 Oct 6, 2017
@wmbutler wmbutler changed the title Show list of open debt positions for smartcoin assets and warn when a position is at risk of force settlement [4] Show list of open debt positions for smartcoin assets and warn when a position is at risk of force settlement Oct 6, 2017
@svk31 svk31 self-assigned this Oct 17, 2017
@svk31
Copy link
Contributor

svk31 commented Oct 17, 2017

image

@svk31
Copy link
Contributor

svk31 commented Oct 18, 2017

Where exactly do you want the warning to appear? Including this information in the account dashboard would add a lot of datafetching to that page, possibly impacting performance for accounts with many margin positions.

@wmbutler
Copy link
Contributor

I think what you've done is fine. Users will have a visual cue from the color of the value under margin positions. Then they will be able to click through to the asset page and view this. Really nice!

@wmbutler
Copy link
Contributor

  • Small bug in the sort order of the ratio column for /asset/bitUSD

See how 667.809 is out of place.

screen shot 2017-10-23 at 11 01 11 am

@svk31
Copy link
Contributor

svk31 commented Oct 23, 2017

Yea I saw that too and couldn't really figure out why it was happening :/ I'll have another look in a bit.

@svk31
Copy link
Contributor

svk31 commented Oct 23, 2017

It looks like it's something weird happening for these xxx-collateral-holder accounts, where the call_price is not updated after the debt/collateral ratio has been changed. So this particular margin position with the 667 ratio displays a correct ratio but the actual call price is much lower.

@svk31 svk31 closed this as completed Oct 23, 2017
@wmbutler wmbutler added [3] Feature Classification indicating the addition of novel functionality to the design and removed [3] Enhancement Classification indicating a change to the functionality of the existing imlementation labels Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[3] Feature Classification indicating the addition of novel functionality to the design
Projects
None yet
Development

No branches or pull requests

4 participants