Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3575 Display error thrown during credit offer create #3590

Merged

Conversation

ihorml
Copy link
Contributor

@ihorml ihorml commented Nov 17, 2022

Issue #3575

Description

Screenshot 2022-11-17 at 20 24 29

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think this kind of error reporting can be applied to all operations, but not only on this page or only when creating a credit offer?

Update: Sorry, I thought it's an error returned by the API node, but actually it's by the UI. Please ignore my nonsense above.

if (base.asset_id === quote.asset_id) {
throw new Error("Base and Quote assets must be different");
}

@sschiessl-bcp sschiessl-bcp added this to In progress in 5.0.230113 Release via automation Nov 18, 2022
@sschiessl-bcp sschiessl-bcp merged commit 67ecb13 into bitshares:develop Nov 18, 2022
5.0.230113 Release automation moved this from In progress to Done Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants