-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSIP62: Close Margin Position #211
Conversation
Please add the Issue to the Discussion heading: #156 |
@sschiessl-bcp a dynamic price or a user-defined MSSR is "good to have" to me, but I think it would complicate the implementation (see also #51). |
I would like to include it in this BSIP, with a note to postpone it to the second next protocol upgrade. Feasible or weird? For me personally, dynamic price makes the most sense. |
No creation fee refund when the order is cancelled. The order should be cancelled automatically if the asset is globally settled. The order should be cancelled automatically if the position is manually closed. The order should be cancelled automatically when remaining collateral in the position is less than the amount selling in the order.
What if the order is asking for more than its debt, due to margin called or debt position updated?
Will the order has an |
All comments up till now have been addressed, resolved where possible. Please have a look! |
Considering the mentioned edge cases I am still wondering if it would not be easier to merely re-use existing margin call logic. Either way, I have added it to the BSIP |
It looks like that we can reuse the logic, but not that simple when coding. I agree to add it to the BSIP though, if it's too hard to efficiently implement it , we can leave it out in the first release. |
@abitmore please approve if you agree this is ready for voting. |
If want BSIP62 to become really useful? It must charge the MCFR fees++Liquidity penalty 1%; #164 If someone want to use BSIP62, the system will charge the MCFR fees ++Liquidity penalty 1% from the user; |
If this BSIP didn't charge fees like BSIP74, it will become very foolish like before. |
I see no reason not too include it as well, can be added to BSIP74 specification. |
Maybe. BSIP74 should have a function of share fees, as this, the Liquidity penalty fee of BSIP62 must adapt with the proportion of share fees. BSIP62 fees will be: MCFR * quantity * (1+share proportion), e.g. if BSIP74: MSSR=1.10, MCFR=0.10, share proportion=20%, so BSIP62 fees will be: MCFR * quantity * (1+0.2) BOB in BSIP74, will sell 100 bts out, and pay 10 bts fees, share 2 bts to the buyer, system got 8 bts. BOS in BSIP60, will sell 100 bts out, and pay 12 bts fees, system will get 12 bts. Thank you. |
No description provided.