Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSIP77: Require Higher CR When Creating/Adjusting Debt Positions #226

Merged
merged 4 commits into from
Jan 28, 2020

Conversation

abitmore
Copy link
Member

PR for #161.

bitcrab
bitcrab previously approved these changes Dec 27, 2019
@bitcrab
Copy link
Contributor

bitcrab commented Jan 13, 2020

if no more change required, possible to merge this ASAP?

@sschiessl-bcp
Copy link
Collaborator

sschiessl-bcp commented Jan 14, 2020

I am wondering if this might need to be reconsidered?

Note: logic around *target collateral ratio* (TCR) is not affected.

Current BSIP only affects initial positions. It is to be expected that positions live longer such that replenishing CR through margin call would happen more often as compared to creating a new position. Essentially, my suggestion is to also enforce ICR as minimum value for TCR (no new parameter). Could have a boolean flag to switch this on if owner desires it.

It was discussed here but not till the end I believe.

@abitmore
Copy link
Member Author

Current BSIP only affects initial positions.

No, it affects updating of existing positions as well.

@sschiessl-bcp
Copy link
Collaborator

Current BSIP only affects initial positions.

No, it affects updating of existing positions as well.

Yes, of course. I think automatic mechanism of the platform should also honor the asset owner desired buffer.

@bitcrab
Copy link
Contributor

bitcrab commented Jan 19, 2020

I am wondering if this might need to be reconsidered?

Note: logic around *target collateral ratio* (TCR) is not affected.

Current BSIP only affects initial positions. It is to be expected that positions live longer such that replenishing CR through margin call would happen more often as compared to creating a new position. Essentially, my suggestion is to also enforce ICR as minimum value for TCR (no new parameter). Could have a boolean flag to switch this on if owner desires it.

It was discussed here but not till the end I believe.

in my view it is good to limit TCR>=ICR, although it is not a must.

sschiessl-bcp
sschiessl-bcp previously approved these changes Jan 28, 2020
Copy link
Collaborator

@sschiessl-bcp sschiessl-bcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted

Stefan Schiessl added 2 commits January 28, 2020 15:27
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
Copy link
Collaborator

@sschiessl-bcp sschiessl-bcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge at your convenience

@abitmore abitmore merged commit e39468b into master Jan 28, 2020
@abitmore abitmore deleted the bsip77 branch January 28, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants