-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSIP77: Require Higher CR When Creating/Adjusting Debt Positions #226
Conversation
if no more change required, possible to merge this ASAP? |
I am wondering if this might need to be reconsidered?
Current BSIP only affects initial positions. It is to be expected that positions live longer such that replenishing CR through margin call would happen more often as compared to creating a new position. Essentially, my suggestion is to also enforce ICR as minimum value for TCR (no new parameter). Could have a boolean flag to switch this on if owner desires it. It was discussed here but not till the end I believe. |
No, it affects updating of existing positions as well. |
Yes, of course. I think automatic mechanism of the platform should also honor the asset owner desired buffer. |
in my view it is good to limit TCR>=ICR, although it is not a must. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge at your convenience
PR for #161.